[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] dom0/pvh: fix processing softirqs during memory map population
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Feb 2022 13:41:38 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4R10ktZCtmCirU7Gcu/ja3tt9ZkhyyzH680Pa3r7kZM=; b=D2jw4KblAs62Lte/8Zd8054m3hXTCQC/sYNbTDgfXnBwBE4DvPKXcYe3At4SmDORIO9+9j3Lto5uW8dDaEIGDiRXeooWdRyuZOxVVtCx7kz7ZkMXAmIqfrTN7p3mCZOPcYPVR3Ka+0VvSpRN6uC4gTATXJnbLI3OmI2byrjFfDhJiXS1YP4wv5JnakfB3KNPRGSC4lUnYxzbPP7vcmkHaUHvsXqAF/RXpY2vGBquRN3JGV/DOtTbbtnf2vWUgPBEN9q+MqrGvwPs4IYvqMMUMeomICFYtxIxmyYgUtF1avKwISp2LeeQUumvX8Vez0+MU9Dff75CXpfL7T5d7De9iw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QQCsllE0Hr2fcXSZy17vYkKMECY3lg4bHblaehz/CRN4f56IzIEItqTkace1I5eoCk5kgaFFfDrsZKgJ4RJ3p2CR7cW6zdmoQjo7lEx1F6pNQw+XSuslnjVSzMKBXCfsHQu+C6PvmQnKiAe65G8pKWCpzWEUmtEol0LZqUdwcEwMddrpyvsfqlGzWrT1ufcFUKw8IMrLGiIf9gl+e865Qzq5RP/6S38xesudmEvbmZWG4BfdVKFrevqYU7weRRpY7kO/tMn/SqHjmbItEHuY/3EtG9bQpXe0+g67tpSyzMcL4m7y90xRMqPXGjUwwPYDJnJti+DPbr8glXbwwE3kYQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 07 Feb 2022 12:41:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.02.2022 12:20, Roger Pau Monne wrote:
> Make sure softirqs are processed after every successful call to
> guest_physmap_add_page. Even if only a single page is to be added,
> it's unknown whether the p2m or the IOMMU will require splitting the
> provided page into smaller ones, and thus in case of having to break
> a 1G page into 4K entries the amount of time taken by a single of
> those additions will be non-trivial. Stay on the safe side an check
> for pending softirqs on ever successful loop iteration.
>
> Fixes: 5427134eae ('x86: populate PVHv2 Dom0 physical memory map')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Nit: I guess it's "and" and "every" in the last sentence. I'd be
happy to adjust while committing.
Jan
|