[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] x86/Intel: use CPUID bit to determine PPIN availability
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 27 Jan 2022 09:15:56 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lk4t9bJ6B9lspMmE404zJ6wngCG49istLQYM/3AUBmg=; b=cJ4FhFEhJLxn95XZMbZr3Ydy7R+eDqQirOL1yNea+8WVP7X181F0BUGzrX2HcE9Tufk9G/M2sqTVHvkqrYakHaDZFd0xy5ge/HGl/9vARUHEaN9feHcUKegr/zsuU7+jzLxqQ6pd2ZwNFFdYPOdXWBNqHkzsVKWoZ0pfvUpV8HiZvLjHhLYHUDb/JDcYcU86y77YQeFTAxNbhlS5ZfAhQsMnIryxEUmiYqmeteBRW7nRNbmAR1q3aM7sHXc4ZZJOmd2lZR4SnScv2q80xS6BNJX6zH9LC2WSamkl1nFivGm/bak1YRkkuKT7ykPlowqeQYEr0jsLcZj/GFQ3/VIYXg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YtALkATXAKH1EGmbnxJz8d533SCUnbrW5T/M6AbSgo9P2234ip7NA2LonoIz267Q64gp/ye84HfkLPdCG7wwzjXPZ5CVtkOSYC2JqCPYLGVdrwVYc/pJT2sW9qzOTZtArMHZQZSmqS0vGstgfpVmdQtRoENEfAe8UGiDquPI6O66gAtz9F7Vl104QdEu/TsyqlzKcOx2QQYsqxm6yUor9NJpR3fEMl8zzSuIMW2uxc+STI3YwFj44TSx3gOFhyx8L3lU1k/vBQbYXYS0oEHV0TjMYbq3rSJj+1E8S7xYXkLaebRsZRG5f/jgunziBM3twiReyP1ZozAPxoKOYAjXYg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 27 Jan 2022 08:16:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.01.2022 08:56, Jan Beulich wrote:
> On 27.01.2022 00:30, Andrew Cooper wrote:
>> On 20/01/2022 14:17, Jan Beulich wrote:
>>> @@ -188,6 +189,10 @@ struct cpuid_policy
>>> uint32_t _7a1;
>>> struct { DECL_BITFIELD(7a1); };
>>> };
>>> + union {
>>> + uint32_t _7b1;
>>> + struct { DECL_BITFIELD(7b1); };
>>> + };
>>> };
>>> } feat;
>>>
>>>
>>
>> Looking at a related patch I've got, at a minimum, you also need:
>> * collect the leaf in generic_identify()
>
> I'll need to make a patch first to collect 7a1, as it seems. It was
> actually 7a1 that I used as a reference, iirc.
Actually that's there, just that I didn't spot it when looking for
the "(7, " pattern in cpu/common.c. This form is used only in
early_cpu_init(), while generic_identify() uses
cpuid_count(0x00000007, ...). All quite inconsistent ...
Jan
|
