RE: [PATCH 15/37] xen/x86: rename acpi_scan_nodes to numa_scan_nodes

[Wei Chen <Wei.Chen@xxxxxxx>]

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年1月25日 18:18
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 15/37] xen/x86: rename acpi_scan_nodes to
> numa_scan_nodes
> 
> On 23.09.2021 14:02, Wei Chen wrote:
> > --- a/xen/arch/x86/srat.c
> > +++ b/xen/arch/x86/srat.c
> > @@ -512,7 +512,7 @@ void __init srat_parse_regions(paddr_t addr)
> >  }
> >
> >  /* Use the information discovered above to actually set up the nodes.
> */
> > -int __init acpi_scan_nodes(paddr_t start, paddr_t end)
> > +int __init numa_scan_nodes(paddr_t start, paddr_t end)
> >  {
> >     int i;
> >     nodemask_t all_nodes_parsed;
> > @@ -547,7 +547,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t
> end)
> >             paddr_t size = nodes[i].end - nodes[i].start;
> >             if ( size == 0 )
> >                     printk(KERN_WARNING "SRAT: Node %u has no memory. "
> > -                          "BIOS Bug or mis-configured hardware?\n", i);
> > +                          "Firmware Bug or mis-configured hardware?\n", i);
> 
> Besides the prior theme of in-place renames not making clear why the
> rename is being done (by deferring to future patches then moving the
> code) I'm puzzled by you replacing "BIOS" but leaving "SRAT" in place.
> 

The reason is the same as I said in previous patch. At that time, I
want to treat device tree as another static resource table. I would change
"SRAT" to "NUMA". And I will try to merge this rename patch with the
actual affected patch.

> Jan