[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/libxc: Drop copy-in in xc_physinfo()


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Wed, 5 Jan 2022 09:36:26 +0000
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Wed, 05 Jan 2022 09:36:56 +0000
  • Ironport-data: A9a23:yKOktqtqeMEU0Sbx+j/+i77UaOfnVGtZMUV32f8akzHdYApBsoF/q tZmKWuOP/jcN2P1fYwkad+x90sP6MWAztNkSws9rCE3FS8V+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYx2YXhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl64OCSjYzNf33tKcSU0ZiExtZF4xk9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6AP pVFN2M2MnwsZTVxB1YaMMI5hduj3CT7XjRy72ONvKMOtj27IAtZj+G2bYu9lsaxbcdahEGDv Urd4n/0RBodMbS32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPWZXutHg1BT4AYgGb RVJpGx+9sDe6XBHUPGjQC+7kWSP7iUwGNVQTNc60ian64jbtlPx6nc/chZNb9kvtckTTDMs1 0OUk96BOQGDoIF5WlrGqO7K8Gra1Tw9aDZbOHRaFVdtD8zL/dlbs/7Zcjp0/EdZZPXRECq4/ T2FpTNWa1473Z9SjPXTEbwqbluRSnn1ouwdulW/soGNtFoRiGuZi2qAsgazARFodtzxc7V5l CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd9rm/3oi76I9oMvlmSwXuF1O5fJ1cFh 2eJ4mtsCGJ7ZiP2PcebnarsYyjV8UQQPYu8Da2FBja/SpNwaBWG7ElTib24hAjQfLwXufhnY /+zKJ/0ZV5DUPgP5GfmFo81jO5wrghjlDy7eHwO50n+uVZoTCXOEult3ZrnRr1R0Z5oVy2Jq YsCbJXTlE0EOAA8CwGOmbMuwZkxBSBTLfjLRwZ/LYZv+yJqRzMsDeH/27Qkd9A3lqhZjL6Qr Hq8RlVZ2Bz0gniecVeGbXVqabXOW5djrC1kYXxwbAjwg3VzM5yy6Ko/docseeV1/uJU0vMpH eIOfN+NA6oTR22fqSgdd5T0sKdraA+v2VCVJyOgbTVmJ8xgSgXF98XKZAzq8CVSXCO7udFn+ ++r1x/BQIpFTANnVZ6EZPWqxlK3nH4chOMtABeYfogNIB3hqdE4JTbwg/k7J9A3BS/CnjbKh RyLBRo4pPXWp9Nn+tf+mq3Z/ZyiFPFzHxQGEjCDv6q2LyTT4kGq3ZREDLSTZTnYWW75pPeia OFSw62uOfELhg8X4Y91ErItxqMi/dr/4bRdy108TnnMal2qDJJmI2WHgpYT5vEcmOcBtFvkQ F+L9/lbJa6NaZHsH1MmLQY4aviOiKMPkT7I4PVpeEj36UebJlZcvZm+6/VUtBFgEQ==
  • Ironport-hdrordr: A9a23:uuizeKGTSbmPldRSpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5 uIGJIeNDSfNzdHsfo=
  • Ironport-sdr: IM0Ix+kE8cxTPn4xFUazzeKhtHFZkco0grOYgpIB9bc6Ilgb7UO7zPohS51OzZKK1NCLV5CIHr LgMn0TAUctPtTgazenOweMbonGrWVB6rbzN3RFYQOG0uaDJj3fj1c9a6Xh0oHKjRewSLQ2hDjJ V0iK0QY6LGqFFAsbywCCFZSPq+VISz84nFVtVdiEDmfI40qpfnoZxSxECYlwqwBHb8mi7Pdwf3 CeJzESr1OYVuasOP6OVM2sygIUjaThKIMftds7Q1dONs3lPZt5bqluBnBBZawmlMrGLmuHaWRz ciqfhkQgf7t3XiGihUoPSGAb
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Dec 23, 2021 at 04:22:44PM +0000, Andrew Cooper wrote:
> The first thing XEN_SYSCTL_physinfo does is zero op->u.physinfo.
> 
> Do not copy-in.  It's pointless, and most callers don't initialise their
> xc_physinfo_t buffer to begin with.  Remove the pointless zeroing from the
> remaining callers.
> 
> Spotted by Coverity.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.