[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/viridian: EOI MSR should always happen in affected vCPU context


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 5 Jan 2022 08:46:34 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sVWqsPpJ0LQyS/S6ZwzactjtLCPSZCYQEZD/Knr37nE=; b=TouHyQON+V3E8yErNN9NlbWDizuf0qRoYROUfeZ4a3OLhnlqszgf3sJHg9Cu2OBgCByXLzIBlvTkKk9Ers763POEPeSkLax529/KX2EqNA61O+Edbkzi6d8TW5/N6dx1U4r93nvq84WhcXAOsE1smAFhxYU0HNC8RmM9xwXbuIXjyqDKl62yKiM6Fh/N2tOOTYNWcY2aO00JkdxHSOOvpwRvQXtTNIEFtk7jPtUJ2z108hWGccp+ZwipvWjAH34qZBlqN8y7IObusSP6yhIYPPeApjNivdb/FGCC0DMiq1sWALctzMZ1gfe5QbGyJ0NY3IYTRYa29jo+xSsYapyLmw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ehi8GZiqjAL1dlZ45j9yjD5ADZJM92M+ODANVOvd+5KCenY1yKagHRfnKS5Z5tqnY1/b5joPeN34jdZG9zu4beMEK4bB22em7K17fh0Qql2FCMvIfarApqYwtslf5nuaWAz/AR2pXV4rIerXxAjBXN78c1NiMl+ZEPpnCw+omKMNMRF72W/bEoDZfBfVZzWeOaw+Ut2Adsd9RAj1FO3IWLBPOWPFhqKKs6BiB4O1pzoYADZ7/E4frsL7HytmLTjWCIBqQP+OH1+7k1ABN1tSz50JoIFnuRc0eZdwaaCFcTon5Kxhc62u3JBz+j/tAiQLyDhTPy3Fd5igUVlvakoEIQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Roger Pau Monne <roger.pau@xxxxxxxxxx>, paul@xxxxxxx
  • Delivery-date: Wed, 05 Jan 2022 07:46:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15.04.2021 11:57, Jan Beulich wrote:
> On 01.04.2021 12:50, Paul Durrant wrote:
>> On 01/04/2021 11:22, Roger Pau Monne wrote:
>>> The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU
>>> as current, as there's no support for EOI'ing interrupts on a remote
>>> vCPU.
>>>
>>> While there also turn the unconditional assert at the top of the
>>> function into an error on non-debug builds.
>>>
>>> No functional change intended.
>>>
>>> Requested-by: Jan Beulich <jbeulich@xxxxxxxx>
>>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>
>> Reviewed-by: Paul Durrant <paul@xxxxxxx>
> 
> Andrew,
> 
> can you please clarify whether your concern was addressed and this can
> go in as-is, or (if not) reply to what Roger and I have said in response?

This continues to be pending. I guess I'll consider ongoing silence as an
indication of your concerns having been addressed, committing the patch
perhaps early next week.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.