RE: [PATCH V2 07/10] iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car S4) support

[Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>]

Hello Oleksandr-san,

> From: Oleksandr Tyshchenko, Sent: Tuesday, December 21, 2021 6:16 AM
> 
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> 
> Based on the following Linux upsteam commit:
> 7a62ced8ebd0e1b692c9dc4781a8d4ddb0f74792
> 
> Original commit message:
>  commit 7a62ced8ebd0e1b692c9dc4781a8d4ddb0f74792
>  Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>  Date:   Tue Sep 7 17:30:20 2021 +0900
> 
>   iommu/ipmmu-vmsa: Add support for r8a779a0
> 
>   Add support for r8a779a0 (R-Car V3U). The IPMMU hardware design
>   of this SoC differs than others. So, add a new ipmmu_features for it.
> 
>   Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>   Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>   Link:
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fr%2F20210907083020.907648-3-yosh
> ihiro.shimoda.uh%40renesas.com&amp;data=04%7C01%7Cyoshihiro.shimoda.uh%40renesas.com%7C995a1c66b6d841ccc79a08d9c3fdf
> 90a%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C637756317833053012%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ
> IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=TirhJToNqy33Fzt0tSpukl9YFOj4iHgd3M1lX8W%2Bxlo%3D&amp;res
> erved=0
>   Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
> 
> **********
> 
> The R-Car S4 is an automotive System-on-Chip (SoC) for Car
> Server/Communication Gateway and is one of the first products
> in Renesas' 4th-generation R-Car Family.
> 
> The integrated IOMMU HW is also VMSA-compatible and supports
> stage 2 translation table format, therefore can be used with
> current driver with slight modifications (thanks to the prereq
> work).
> 
> In the context of Xen driver the main differences between Gen3
> and Gen4 are the following:
> - HW capacity was enlarged to support up to 16 IPMMU contexts
>   (sets of page table) and up to 64 micro-TLBs per IPMMU device
> - the memory mapped registers have different bases and offsets
> 
> Please note that Linux upstream doesn't support R-Car S4 SoC
> yet unlike Renesas BSP [1], but it was decided to reuse upstream
> patch for R-Car V3U anyway as the IPMMU HW settings are similar.
> 
> [1]
> 7003b9f732cf iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car S4) support
<snip>
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>

Best regards,
Yoshihiro Shimoda