[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/arm: fix the build error for GIC on ARM64 QEMU Platform



Julien Grall <julien.grall.oss@xxxxxxxxx> 于2021年12月28日周二 20:30写道:
>
> Hi,
>
> On Tue, 28 Dec 2021 at 12:37, Dongjiu Geng <gengdongjiu1@xxxxxxxxx> wrote:
> > > Please don't update tiny64_defconfig. The goal of tiny64_defconfig is to
> > > have a config with only the bare-minimum. If add CONFIG_GICV3=y, then it 
> > > will
> > > be enabled when it is not necessary.
> >
> > Ok,we can let the user configure the CONFIG_GICV3 in tiny64_defconfig
> > according his neccesary.
> > So I think my modification does not affect the tiny64_defconfig.
>
> But you modified tiny64_defconfig. Anything you add in it means it is
> going to be enabled by default.
>
> > what
> > is your concern about it?
>
> As I wrote before, the goal of tiny64_defconfig is to enable the strict
> minimum. I don't consider GICv3 to be part of this.
>
> Instead, we should let each user decide whether they want to include it
> depending on the platform they are targeting.

Ok, thanks. I think we should not consider tiny64_defconfig,  because
the user can decide whether to use GICV3 or NEW_GIC.

>
> Cheers,



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.