[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [BUG] Resource leaks in Xen
- To: Ryan Cai <ryancaicse@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 22 Dec 2021 10:28:10 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ST1XzSg4MtBdb52NTwXfc6sVlyAu8tikSBdV/sJa0To=; b=FqdsJbLipwltjaxCuThFL04edPZ+LUUtBiXXdStorXsYpG3gApQalda6AU5kkZim63miUiwAv3STH/wmlWCtr0Q+puKb0h5lkV5Cd3s8/HsXOpfBwkOXVSPZZe7z48pwQlKBfOtk232U2L0upx8blILqjjGRBu18ddo2H/hkoUAGFV0QdkR9NE7Q2o7v3HtDwveGLfSPxvLacrxDFXX57fnHFkkQzIO8JjX/cnLeIPcQmEbU+wdNEsCJEOevdI+Ob4V2zKUiGB3XVWrdPGrVMPxrHqVcBs/May2Az2SXeCrSuDR3a40wuI5X3RX6IVhIICWsemgDwGQj8GI3V0cYLA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mT8DPcyTehihLLbuaRNexhSBdiZDiznhJAMDbHhu+Cc4Tl6gQY5+4osFWzf6/DCJYaCE8zjhul2WXiwrGK8f1nMeFcQKXvJ4ZzbOZ5pOVhQe0Ri+xqaWfg+cQkq5j14UIW2ol48zv0aXZCkZDeHM3LsXgMizOKW63D+wdA+glJcVroVN+2meePuR6WLS2FiFk3jv1wyUBM9XK44T1S77Xh1wx1WGWFTFbxd4tPuvnYlUiIR1Kh9yqwJw6h54taNodzhg4/M0gYTlJRzQbkz4DfTw4mM5LwWU900Z3QoGvx3SLU5IMdlSVRTopRWtse67dVFZQzagnFD1Ji9eNNO1gQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: dgdegra@xxxxxxxxxxxxx, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 22 Dec 2021 09:28:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.12.2021 09:05, Ryan Cai wrote:
> I am writing you to report potential resource leak bugs. In the
> file /xen/tools/flask/utils/label-pci.c, the methods fopen and fclose may not
> matched when returning at Line 76, resulting in a resource leak. Looking
> forward to your feedback. Thank for checking.
>
> Locations,
> https://github.com/xen-project/xen/blame/25849c8b16f2a5b7fcd0a823e80a5f1b590291f9/tools/flask/utils/label-pci.c#L63-L76
Thanks for looking closely, but I'm afraid I don't see where any
resources get leaked here: "f" will get closed implicitly after
returning from main(). It might be good practice to close files
explicitly, but that's purely cosmetic here afaics. Feel free to
contribute a patch.
Jan
|
