[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
- To: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 17 Dec 2021 08:12:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SmHn+CnE6itoxRgrD97ITmCMKimndrn8qe9Do/IYSzU=; b=Zxa07Dpp1QMduhlGeibYuWr5DFVZgwoN3JShHHxPUBw2y0OFpYyLnPtdF0Hp1UjBBmpsJbdto/m9NCTXoI7XOUqaY8kqtYqqURlfE8jEuJhfXOg9KxaOfstzfkYuR9Ezpr162gQYpCZ2w0ZBzHTNUWakaM07Xqc7yYMcjeNV133uGC+F/e4JGtkmv1t9JiPzyHMjLjt3ZDiidM6/6kTlj34U7t95Opp87PaX3WGWU7qAN+RZetW7SgsPpzwUMiBUwitzgMDmyPGN4Qs7fSZ0+k2ZecvufLYJmMXpLfErrnlCqMUlFLlS20UoVvW0vb1GWEEtSVM6y239IzTGzSB8Sw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k0h9SYulNKY2rwcVrBUy9CRVkDZGUTmTQIApR0EkoG0nXKM/XXOt3sEL/OwODgfuZgSHmQviQJQ7z0F5Ykg7jUZmNFvlt3u7EuwX/CCghLhHuDwZbScAjysY62ijNjh4gfcpro2fkyyNzh4L6lZMwNV1ff+l/QRtclD4jWdFFyiJwZ55pth8RaatuGUgoHmQ7C5VWjy8j4+k73kX8ZvM/0NiGa5FmxbtvsANokydBAhDWBuSezIL+alOKyX+CXfDawGpa5gMt7JZXjoemGHCHQuIMr4m5B56Pu719IvdlhakuknOowDt3Vsn1LLwLeWuDru5NKnrI+NNvBsCPixAtw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 17 Dec 2021 07:12:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.12.2021 18:36, Oleksii Moisieiev wrote:
> On Tue, Dec 14, 2021 at 10:41:30AM +0100, Jan Beulich wrote:
>> On 14.12.2021 10:34, Oleksii Moisieiev wrote:
>>> --- a/xen/include/public/domctl.h
>>> +++ b/xen/include/public/domctl.h
>>> @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
>>> #define XEN_DOMCTL_vmtrace_get_option 5
>>> #define XEN_DOMCTL_vmtrace_set_option 6
>>> };
>>> +
>>> +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
>>> +struct xen_domctl_sci_device_op {
>>> + uint32_t size; /* Length of the path */
>>> + XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
>>> +};
>>
>> This being - aiui - Arm-only, please enclose it by respective #if,
>> just like we do for certain x86-only ops.
>>
>
> I agree. I will add #ifdefs in v2.
>
>> I'm further afraid the term "SCI" is ambiguous with ACPI's System
>> Control Interrupt, so there's some further tag needed in the names
>> used here.
>>
>
> Thank you for remark. I'm thinking about SC as System Control.
> What do you think?
I guess "SC" could even more so stand for various things. Even the
spelled out "System Control" looks overly generic. If this isn't
Arm-specific (in which case adding "arm" into the name might at least
help the situation a little), then I guess some further disambiguation
is going to be wanted. Since I don't know any of the context of this,
I'm afraid you're in a far better position than me to come up with a
non-ambiguous name.
Jan
|
