[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
- To: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 14 Dec 2021 10:41:30 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V6Fc1grdlexpszAPWZbZ1T/t6DpZ80ZnT6ApIGLSZVw=; b=m5ZgAjOlHsi//DlpMxnCb2kl/nGfqh3ZLYutXo2MvPVDy9Y9TVzTyshKYZOLckA8QRksg+NpSUZvoe9WvrZ+wu1EQLgJrUCZPrHoGOeG0u+oRiaL0F3BVCW1eidD4aTS+G1MNh1bK/6cZhQDQiramfcLPHMM3t7iVSxtkN1NqzNsftsscNBaP+evOg4ovK9GTIdjEgIDxA+xMUjBz292zMoMvD+em5ZyYcg6QNHONZpGc/19wG8VPcMonZHxSNwKBl+VtgLsyPDqFYakBATQxV030TIKfMX6fCXEMZ7ClhZsYcuYZPkfO5gaLw8fHHJGatgFr+i829pruLicjHt4tw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cRvSVeIfPkJyfwFMS+SxRQ59GA418Ztax2UkZvHLg3RrYkjmOgixj0ordOA4REr9npGWK9q8Rkd49pZ+MGl0XnOQoZtM+Jf0OM8sK/IPTCI1V5hToa2xa6Q1WJnaodQ+OsxFMwZ2HR66TDy8NHM2hVHKO7nXKwJWhITEOS68EgAwyNUkJmDnoy8XQ4JYF7IQi5e7FrK4N23j7v4rb0DVxZti1MgkmS6axym/cXbNWZgwAjI1uQ9KICT0edBREBfVv08hZAMCZ/aEdf13BBBEWh3UqMqZgLHEtsxQ8CpxWk2ckPnEEsdnmbF7DIaef/262iIbMvGPzb4mNyBBM4x0xQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 14 Dec 2021 09:41:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.12.2021 10:34, Oleksii Moisieiev wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
> #define XEN_DOMCTL_vmtrace_get_option 5
> #define XEN_DOMCTL_vmtrace_set_option 6
> };
> +
> +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
> +struct xen_domctl_sci_device_op {
> + uint32_t size; /* Length of the path */
> + XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
> +};
This being - aiui - Arm-only, please enclose it by respective #if,
just like we do for certain x86-only ops.
I'm further afraid the term "SCI" is ambiguous with ACPI's System
Control Interrupt, so there's some further tag needed in the names
used here.
Finally please make padding explicit and check that it's zero on
input.
Jan
|
