[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 03/10] iommu/ipmmu-vmsa: Add helper functions for "uTLB" registers
- To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
- Date: Tue, 14 Dec 2021 12:05:45 +0000
- Accept-language: ja-JP, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UWR7wCZTh48p5KfsTZ1X+ycSMn64E2sBRAYS2QGRP3E=; b=QSAUifmDOP0GKgxlVr6abttTi/PVbDoHBQ8zrvq0zyAU0BNKcWYAu26Ru0sVHRup0aR4udTmCw6e48pVFg/LVNF59KZ5xmNaxEaIh/HwdO5unE2zsBKnMLfyXLGQ1VGMBjVvrP4QfPOEn6+vB7Ta6i+hFmlbUcGJwdKBTrGxR5O6GeqVmmBx9Wh2fq2O6RwBHOlv26aJaIELGO7BnLxj3D1nCmQAgTCrqmke543xu3xKescLjDhJkjHpLRkngMCKylAIiJ7CT/bN2B5l3UZPjb+GeREjm6DYWXi3ILWoS99htUcdUzj4z+FLs8DoT3VWtoTwiV3dFtjsD3mQrT0BQg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CAN5QOoZ3Lr1THJhgTjh9Hiot44AtBL96LK0xqPGnhIjCJk51fsQQY41HCYInRmjU30NdoGnCC6j8FlF4PFRl8MsElhPfXE3nDlcn1TDPCuESLo/mzjQFkUEJ/g1vQRNy/YshDqVyyjxke/ui5WNguAs7ScZM74uucgYP7TrbzvS4+auHsedioZKOjUT9RRuxxzh0w+ByXvKiynLQLc9iYIRI6ieO0DveW4XW8Z9AUL4PdJamxYbrztwrlwR7naw6jg5cbNSQUoMdVgfsorQjf1g5y6SCEt0RK6K+63sauJXkm4SQFtZO1O9kmh5mAY1I2T5mbVVf18WYXazSoJ5gA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com;
- Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Tue, 14 Dec 2021 12:06:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHX47d6jEgJuhJME0m5DFdy3SZFF6wx9csg
- Thread-topic: [PATCH 03/10] iommu/ipmmu-vmsa: Add helper functions for "uTLB" registers
Hello Oleksandr-san,
> From: Oleksandr Tyshchenko, Sent: Sunday, November 28, 2021 2:52 AM
>
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> This is a non-verbatim port of corresponding Linux upsteam commit:
> 3667c9978b2911dc1ded77f5971df477885409c4
>
> Original commit message:
> commit 3667c9978b2911dc1ded77f5971df477885409c4
> Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Date: Wed Nov 6 11:35:49 2019 +0900
>
> iommu/ipmmu-vmsa: Add helper functions for "uTLB" registers
>
> Since we will have changed memory mapping of the IPMMU in the future,
> This patch adds helper functions ipmmu_utlb_reg() and
> ipmmu_imu{asid,ctr}_write() for "uTLB" registers. No behavior change.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
>
> **********
>
> This is a prereq work needed to add support for S4 series easily
> in the future.
>
> Besides changes done in the original commit, we also need to introduce
> ipmmu_imuctr_read() since Xen driver contains an additional logic in
> ipmmu_utlb_enable() to prevent the use cases where devices which use
> the same micro-TLB are assigned to different Xen domains.
>
> No change in behavior.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
Best regards,
Yoshihiro Shimoda
|
