[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 02/10] iommu/ipmmu-vmsa: Add helper functions for MMU "context" registers


  • To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
  • Date: Tue, 14 Dec 2021 12:05:35 +0000
  • Accept-language: ja-JP, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MsUZgLCtyKsEdNuXNMxlfctoNkMMKk3ukpTp2QX20ms=; b=R9I3WiJYKMnk3nuJ/74T34epGZjdRrM07SZ0FlXB5fhN88yxrOE7AUyyX2epyuzfFRqlfNndqNx6FzGhBgnF/fJCZQ4MxZDI5kBuVU0ggYVxPnHGaE/gUJVYEHnzCRPG+12u398IuMnFlL4nfD48pFOI1/dmAOxNBJfhAfF+7JUXaJM3JDbsDRLpr/NwSO8+/E6qGs35ERQSfWBI5Ul7ztSE9EVcCdx5Y3Jr5B0MvgrnLhRLIg3LOPXlKjzPCiXUiv6B+X2n7j9Qjj/kUTFGnYSRPgS2OvdsyQnBf67dDNdHVOUcteqP957K0CBe2Kx5igquvA4tgeGaHcpzeDy4SA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IjDdXU8kMTdsrYUZ6o8iDgTHchv2u2P7drPLiaIRXZqpXRYRzfRCfsNd8BLfqJd/zOJQW4s3KW8Ysb4RZTAZ2RdMqs6Wy1/3IJzKM2lH6IoThBrxnsFlHnRkl08z5WGS7RvnP+BXPJosmoxT6fG/62bI/3yWKZwo4eBFI93u04S5lnKjhnTwZuwZXhRy12ykEPeWOOMooysoFbc2Tb2RytFFVqQqCe1uTUYdafZ/eti9VoSecGcKatXTATxsHc5mcqnRMyhBy36+W5NLYa9R58HJt4YnDd/Yf/nIx4cFk0B4KsFqj2iUHWY0vC4mDaNGIAkVUtAoVs3CpFMYIyzbLA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com;
  • Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
  • Delivery-date: Tue, 14 Dec 2021 12:05:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHX47d5bUBAY0i+EkObsnwBPyqCUKwx9ZHw
  • Thread-topic: [PATCH 02/10] iommu/ipmmu-vmsa: Add helper functions for MMU "context" registers

Hello Oleksandr-san,

> From: Oleksandr Tyshchenko, Sent: Sunday, November 28, 2021 2:52 AM
> 
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> 
> This is a non-verbatim port of corresponding Linux upsteam commit:
> 16d9454f5e0447f9c19cbf350b35ed377b9f64eb
> 
> Original commit message:
>  commit 16d9454f5e0447f9c19cbf350b35ed377b9f64eb
>  Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>  Date:   Wed Nov 6 11:35:47 2019 +0900
> 
>   iommu/ipmmu-vmsa: Add helper functions for MMU "context" registers
> 
>   Since we will have changed memory mapping of the IPMMU in the future,
>   This patch adds helper functions ipmmu_ctx_{reg,read,write}()
>   for MMU "context" registers. No behavior change.
> 
>   Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>   Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>   Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
>   Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
> 
> **********
> 
> This is a prereq work needed to add support for S4 series easily
> in the future.
> 
> Besides changes done in the original commit, we also need to update
> an extra call sites which Linux driver doesn't have, but Xen driver
> has such as ipmmu_ctx_write_cache(), etc.
> 
> No change in behavior.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>

Best regards,
Yoshihiro Shimoda


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.