[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 02/14] vpci: fix function attributes for vpci_process_pending
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Sat, 11 Dec 2021 08:57:11 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=99nK2sr9zhnAvkiKxB3DoZv/nFevP8TNWfxcbsWK5Uc=; b=GrvRRG/nkaEsCtR24HmyjBF1j8eL2uI38TwRWP3N3d2cz/eTiqghOFfQltL09XA3TiFppjmwzIQREqVmyU5qjYXq5pKowjqwqghfN7Oc3Be0SdjOCSS2hRpi5+364tb1wDGwhDvALhmBFWxkINkZUarZaAsDm9bo9GrsiNNHU8f40cJQ3BZCYvwnJ2QWzrFBUtJaLzWBWmdiPy5tdq/goSNr++UQJapfjCq0H/6PKjM2gZ4OhVCT2iM72FvH0E6eMFM1CyNwp0fQ/Uwl1y02V4+JYfKImDlQJNb+pOXc0M1gMWh3CKBprwqS/HvNpha/mP1tplG/Z5q7bRX3icmdrw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aRH+mo9x9rj/pNeLjqEiaYuT2aFdsOaEYF2JQM3lXpE8TNhPBwdYdIAAv0kF4e1IH+ftf3Jx3rmk5Loj1YUgDu+nnPGMBfna7fvxA386KCnjj6z+qd1yKQoYE6DZLRmSpTC3d+LEQQsfOCh8UOC17DXdZatP9nXVoHBVygmWwNg8Q74vmEr/P0g4DSfOknmwWCxtUnlcK513KWAVdMmy8OMU1CMCshKG0tLK4w0bvtWtPBkgDHP1qV2ktHXiuhSSzUYV/GCspPA2vP8uWpfc3VED/A3f1EYL53bNAW1hUU2+YDjmUa6hXDQ3VYaVoUmohkDtwUgWbAFks3D1XP+9Sg==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Delivery-date: Sat, 11 Dec 2021 08:57:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHX4ewFDAQe3UpzbkCO75DuGK42PKwsGkWAgADxxACAAApIAA==
- Thread-topic: [PATCH v5 02/14] vpci: fix function attributes for vpci_process_pending
Hi, Roger!
On 11.12.21 10:20, Roger Pau Monné wrote:
> On Fri, Dec 10, 2021 at 05:55:03PM +0000, Julien Grall wrote:
>> Hi Oleksandr,
>>
>> On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>
>>> vpci_process_pending is defined with different attributes, e.g.
>>> with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
>>> Fix this by defining both of the definitions with __must_check.
>>>
>>> Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a
>>> shim-only binary")
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> I think this can be committed independently of the rest of the
> series?
I think so
>
> Thanks, Roger.
Thank you,
Oleksandr
|
