[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 02/14] vpci: fix function attributes for vpci_process_pending


  • To: Julien Grall <julien@xxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Sat, 11 Dec 2021 09:20:22 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qduQJK1aJ/OpYlgPhAQKCDZd348zfSiOpXZtUAoZnbI=; b=ZLPlzyvTyHelug5T+xIi8iydxm7Q9dO1Sb8hXABJM0ZgN2HspQ9ulrwUAkTKb/03lTHVcnGlctzG+fzmHIFxmmSJDcR91rPzFsYlbpHB7fgwtctmPfcKIKRbxSTbm8lDTFeaDTq4QRzUzntvWDJTTRjAk9qOzRXch8nRQU7RIrOVF6JptZy5ag3O8LpBUEuzWwl9bCb79F9X9+o3P/BMyibEF+EEeGKcYsK+73cXilwbAk6R19ASfiavYd6y48ZdQQCt7XvhNjfmeXVdHbe8K2JXFJtWICBEfjQJclg8mpA/DratxxQhYSpOzJZHeXJjNE5NAQMbdpbHnX6iq9ZC1A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hc9uNwURvMmpyqsrgP7o8ENsgWWk14MenImwr59sBdbF9+iuiGhNyZRHbYsjYEZaI85TQwaI+m0H6FIunR6ddsgoepq2AnvkwRRpn4S6LktAWBFfbSVepC7peaCkJfFnTtb3yG6oneeItu+dQHD2KSJRdnmVIzzQng77iDblkhVoaU58uUUM3VsJaFSznB7ZB/NHgpy6TFY0hrsbn92ogwzWJiF1tIfZDwjBbfd+gbK89JvcgeU70HCJLXLHocClLR7eEGecqkQFz+Xqi9xrxBh60exRJTcCWjb+SPbUJhk5lMC4CPhiRTpzVcI7RpR6H1b6X+nIJ8XBc8K+dOp2hA==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <sstabellini@xxxxxxxxxx>, <oleksandr_tyshchenko@xxxxxxxx>, <volodymyr_babchuk@xxxxxxxx>, <Artem_Mygaiev@xxxxxxxx>, <jbeulich@xxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <george.dunlap@xxxxxxxxxx>, <paul@xxxxxxx>, <bertrand.marquis@xxxxxxx>, <rahul.singh@xxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
  • Delivery-date: Sat, 11 Dec 2021 08:20:55 +0000
  • Ironport-data: A9a23:Vwuq2KMxtrx3sV3vrR2QkcFynXyQoLVcMsEvi/4bfWQNrUpzhD1Um 2IYXz3UPv+DM2OjfNgibonjo08Eu8fcn4BgSwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s7w7VRbrNA2rBVPSvc4 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxDRu/A26 e5WjLC5RFclb/b2wusFQhYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uTtYIBjWZp7ixINdWGZ O0TMgA2VQqaPQRJPW8wLYkfvc790xETdBUH8QnI9MLb+VP71AVs1JD9PdyTfcaFLe1XlEuFo mPN/0ziHwoXcteYzFKt22iwi+r4uDL0UYMfCpW17vdvxlaUwwQ7DxkbVkCyp/WjvUe4V8hCM Ewf+icorq8a+VSiS5/2WBjQiGSNvgMYHcFRFeI6wAiXz+zf5APxLmIJVCJbYdoq8so/XyU31 0ShlsnsQzdotdW9WX+bs7uZsz62ESwUNnMZIz8JSxMf5Nvuq511iQjAJv5qFqKv1IWtQRn/x jmLqG41gLB7pcwW06S2+3jXjjTqoYLGJiYr4QHQUnOg/xlOboevbIy16nDW9f9Fao2eSzGpu 3wJmNOX6uwUOo2cjyyGQOgLH7aB6u6MNXvXhlsHN4I66z2n9nqnfIZRyDJzPkFkNoADYzCBX aPIkVoPvtkJZiLsNPIpJdLqYyg38UT+PfG9ctCTT+FVW7R4eV+LrXpUP0GIzm+4xSDAjpoDE ZucdM+tC1MTBqJm0Ce6So8h7FM7+swt7TiNHM6mlnxLxZLbPSfIEuldbDNie8hgtPvcyDg55 eqzICdjJ/93dOTlKhfa/ocIRbzhBShqXMumwyC7mwPqH+aHJI3DI6OAqV/CU9Y890iwqgsv1 iviMnK0MHKl2RX6xfyiMxiPko/HU5dltm4cNicxJ1uu0HVLSd/xt/ZGKcFuJOh4qbELIRtIo x4tIZroPxiyYm6fp2R1gWfV8uSOiyhHdSrRZnH4MVDTjrZrRhDT+8+MQ+cc3HJmM8ZDjuNn+ +fI/lqCGfIrHl0+ZO6LOKPH5w7g5hA1xbMtN3Yk1/EOIS0ABqAxcHev5hL2SulRQSj+Ksyyi 1zLXExG/LaV+OfYMrDh3Mi5kmtgKMMndmJyFGjH97emcy7c+2uo24hbV+iUOzvaUQvJFG+KP I25Ftnwb68KmkhkqY15H+o5xK4y/YK39bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC xzXotQKa6+UPM7FEUIKIFZ3ZOq0yvxJyCLZ6u44IRum6XYvrqaHS0hbIzKFlDdZcOluKIogz Op44JwW5gWzhwAEKNGDiiwIpW2AImZZC/cst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f m7K3PLP3u0OyFDDfnw/EWn28dBc3Zle6gpXyFIiJkiSnoaXjPEAwxAMoy88SR5Yz0sb3rsra HRrLUB8OY6H4yxs2JpYR2mpFgxMWE+Z90j2xwdbnWHVVRD1BGnELWl7MueR5kEJtWlbe2EDr r2fzW/kVxfsfd3wgXRuCRI09aS7QIwj7BDGleCmA9+BTsszbjfSi6OzYXYF9kn8CsQriUyb/ eRn8Y6cs0Eg2fL8d0HjN7Sn6A==
  • Ironport-hdrordr: A9a23:wH1q5alC2DdKh84rpkxiJiRohwjpDfIi3DAbv31ZSRFFG/Fw9v rDoB1/73TJYVkqN03I9ervBEDjexPhHO9OgLX5VI3KNGOKhILCFvAA0WKN+UyEJwTOssJbyK d8Y+xfJbTLfDxHZB/BkWuFL+o=
  • Ironport-sdr: yrTFKejHGsgX7QoGmqyEXb8C4YEjJCNpH/+/OrkuQvGCS8yPD8AgkTKp+ogg2ZtxiBVYMb1LDe kRl5UUBCOMzBcT+gZt9qDPdwuNs4p6uHRmBoTsG5+T5nu3y7IOTLF23gsvUeKuKQArZYQS4wVp vXqjYJbUO8Vh0UROFF0IKgyvYV9TbUC7KB2qEfDymZRKMi97VpW8jQpX+6IQR9os+YB+fwwWJt iIOJHqR09sqhBMbUckg6lPlXfJhuWtmkX+1O3Zye4IF9B8+rUn6f/fGqNzZsKtvKJsbWe2WOtY UTerN3jf26ir+ps9OlmKioNY
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Dec 10, 2021 at 05:55:03PM +0000, Julien Grall wrote:
> Hi Oleksandr,
> 
> On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> > 
> > vpci_process_pending is defined with different attributes, e.g.
> > with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
> > Fix this by defining both of the definitions with __must_check.
> > 
> > Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a 
> > shim-only binary")
> > 
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> 
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

I think this can be committed independently of the rest of the
series?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.