[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] xz: add fall-through comments to a switch statement


  • To: Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 6 Dec 2021 17:24:34 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6EGC4bhYg8Cm8dTR5PZqCzbg4FNGIQQt/WhIZIz7lAA=; b=MGl3sfDAuDykz6LwdIqNwEMGOkW7uoxsLt1C9BZwMqsINDO6zdJM90lxnQ/qewXNiVqPdGh0oTzL2rKohgP0RpZIhaObk7Rd7rk2WXblPky6qfoxyj+Zt8406ranubplG+v3XjnjsUNGCidNNOFB3Jm9c6U3FJR3iXb7jfTY3DRqFf67orbckx2eyjQFBR1UDMP5ntGjPiNfJJV63gIEdAA0zkkGFUEC9occyYVimTpi+k9QBIgOz8s9mvKLatntMXIGx/AZQ6SQj+q7VshKk4a89MnvabFc4ypA6Ku/hKWHVdAQRXGcpirrW3RMJwf1IJDSkMvG6Dz5sOFiRr+JjQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hnxE+LWTFrVP1zRLLw0bkPsblVNW4Aw69vTKIBzpjV3DZwFFMWW1tCCXqMu8PX4jSxiWVBmBQ2kc9e6XD3ZYn6feSw7ns6n4H7eBafZsQ3PgIVC5s9vHl7ovkLIREB6PyTI/aUud2FuIifVofiTrNHEpnKvkZm90H7xnE+q3+9Y+7CyNHGWaVfX0lkupMhMRWnTxe3gtYyLItR9rWgabud6ndzDP+dyOr8ML1eaxy0R4AdKZT2C2GLs1aHztvaIwu315QoK07H4LhU+aeFoeXpUNt/qL7KjqBr6OFYDAABXNs7nOIE7MZZe4R+Sa670Jm5vyLhjTq83aYbgj/V/Ysg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • Delivery-date: Mon, 06 Dec 2021 16:24:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.12.2021 17:21, Julien Grall wrote:
> On 06/12/2021 16:12, Jan Beulich wrote:
>> On 06.12.2021 17:06, Julien Grall wrote:
>>> On 06/12/2021 15:06, Jan Beulich wrote:
>>>> On 06.12.2021 15:28, Julien Grall wrote:
>>>>> I am not going to ack it but I am also not going to Nack it if another
>>>>> maintainer agrees with your approach.
>>>>
>>>> FTAOD I'll be giving it a week or so, but unless I get an outright NAK,
>>>> I'm now in a position to put this in with Luca's R-b.
>>>
>>>   From the check-in policy section in MAINTAINERS:
>>>
>>> 4. There must be no "open" objections.
>>>
>>> So I think this cannot be check-in given two maintainers disagree on the
>>> approach. That said, as I wrote earlier my condition for not Nacking is
>>> another maintainer agree with your approach.
>>
>> Hmm, I did address both your and Ian's concerns in v2, admittedly by only
>> going as far as minimally necessary. I therefore wouldn't call this an
>> "open objection".
> 
> I believe my objection is still open. I still have have no way to verify 
> what you did is correct.
> 
> For instance, the tags in patch #2 are:
> 
> Link: http://lkml.kernel.org/r/20191104185107.3b6330df@xxxxxxxxxxx
> Reported-by: Yu Sun <yusun2@xxxxxxxxx>
> Signed-off-by: Lasse Collin <lasse.collin@xxxxxxxxxxx>
> Acked-by: Daniel Walker <danielwa@xxxxxxxxx>
> [Linux commit: 8e20ba2e53fc6198cbfbcc700e9f884157052a8d]
> 
> The tags in the Linux commit are:
> 
> Signed-off-by: Lasse Collin <lasse.collin@xxxxxxxxxxx>
> Reported-by: Yu Sun <yusun2@xxxxxxxxx>
> Acked-by: Daniel Walker <danielwa@xxxxxxxxx>
> Cc: "Yixia Si (yisi)" <yisi@xxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> 
> * The first two matches the original e-mails
> * I couldn't find the 3rd on the ML.
> * The Cc could be ignored
> * The signed-off-by are I guess what you call "mechanical"

Am I understanding right that now you're complaining about me
having retained one tag too many? So far all discussion was about
too few tags.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.