[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12
- To: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 18 Nov 2021 09:33:32 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SK0g71aPS4DeWVUriS6RFJbsGDjmSYdetg4JMbE7GrE=; b=OPddE+3+m1f8xatItWtQNj9ezo/LS4BHEAZyley1W563Cs6VKMdlz/KYqRfcIRrf8x85nVN5qhkqzT4fTRGThAYCazUg8rQYvH5FiNWw8W0vGnLAVjJZXo4iieq9i/1/+h8SOuUja//2HoqHc6JKz7HAIxieS2SXZTWOvXj3spiAf2ghbnE+xkFDMtB1I+v03wbVrO2OQZrbH7NJZsMPrm2Hmq/HOz60hMXue4JeBZp9lVnrtKo6XQCiobPj8nYG0S8lJpRymqf4DMovp3diCYM2cmitihBGOv6bzvKBWiPUJIx2SUzxQmntqCA/kW4GYEr5TQZgmBEJ4HnjpsW5qw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c6tEQzw+2DPuc2inXhtpzbhozjkgAbmdduD6znsCXYydRSbDx9HFpN3e9Vh09isi9YxXFvcD1JJJNUIwkbZxRO3V1fYI0J95B3l/qnERBmsv5ODs0V4NuhsJlBO3Udc9Tw183rNUiLIM+nPYqphfAdkrczyLYr6ob52KVf3Eyz/SrlmbeZc8MdiLO/4R6sWSf8i06yGIXCWaF7zsZDDSH08vnC/TZodrW/3+0gs2ZseSZwAInOoQ6TknA3uBoNwSnlcSqrq+0hJY0XEGD4Wsc0W2n15LrjcPCQF7YPok6h+86aZrEeCyRbv/7C2Bns53MBipDb5cIMCLGQLBHIC6Lw==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 18 Nov 2021 08:34:09 +0000
- Ironport-data: A9a23:52YhV6N5Ovg7ffTvrR1PkMFynXyQoLVcMsEvi/4bfWQNrUok1TYPx mBNUWiAafePMWuhfYhxbonip0JX7MKHyNdmTwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Eszw7dRbrNA2rBVPSvc4 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozDZxZdz8 slQjrq1c0QnHb3ekc8EXiANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uSvY8Jgm1o7ixINefEX 5QJZwNFVhHrODFGPAsPCq5ug9790xETdBUH8QnI9MLb+VP7zRNz+KjgNsLPfd6HTtkTmVyXz krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M/pAL 2QE9yxoqrI9nHFHVfGkAUf++iTd+EdBBZwASIXW9T1h1ILRs1zeBFIYUwVnbeZluuwmVzUBz 1KwyoaB6SNUjJWZTneU97GxpDy0ODQIIWJqWRLoXTfp8PG4/tht00unosJLVffs04arQW2YL yWi9XBm390uYdg3O7JXFLwtqxalvdD3QwE8/W07tUr1v1oiNOZJi2FFgGU3DMqszq7FHjFtX 1BewqByCdzi67nXyERhp81XQtmUCw6tamG0vLKWN8BJG86R03CiZ5tMxzp1OV1kNM0JERewP hSM4FwNucMDYSvwBUOSX25XI552pUQHPY67Ps04k/IUOsQhHON51H8GibGsM5DFzxF3zPBX1 WazesewF3cKYZmLPxLtL9rxJYQDn3hkrUuKHMiT503+jdK2OS7EIZ9YYQDmRr1os8u5TPD9r o832z2ikE4EDoUTo0D/rOYuELz9BSRhWM2t9ZUILrXrz8gPMDhJNsI9CIgJIuRNt69Uiv3J7 je6XEpZw0D4nnrJNUOBbXULVV8ldc8mxZ7iFSBzb1uuxVY5ZoOjsPUWe5ctJOF1/+1/1/9kC fICfpzYUPhITz3G/RUbbIX889M+JEj621rWMnr3eiU7cr5hWxfNpo3ucDzw+XRcFSGwr8Y// eGtj1uJXZoZSg1+J8/Kc/bznUiptH0QlbsqDUvFK9VeYmv2941uJ3Cjh/M7OZhUex7C2iGbx 0CdBhJB/bvBpIo88d/og6GYrtj2T7siTxQCR2SCtOS4LyjX+Gan0LRsaufQcGCPTn7w9YWje f5Rk6P2PsoYkQsYqIF7Cbtqk/4zvoO9u79Aww14N3zXdFD3WKh4K3yL0MQT5K1AwrhV5Vm/V k6Vo4QIPLyIPIXuEUILJRpjZeOGjKlGlj7X5PUzAUP7+C4oo+bXDRQMZ0GB2H5HMb94EII52 uNw6scZ5ju2hgcuLtvb3Dtf8H6BLyBYXqgq3n3A7FQHVub/Jol+XKHh
- Ironport-hdrordr: A9a23:2vBHmqo3Mn5VDy/82/NL1+0aV5u3L9V00zEX/kB9WHVpm5Oj+f xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGMaGJ2IrT0JcTpzencGNTWubqBJba Z0iPA3wAZJLh8sH7qG7zQ+LqX+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G CAymXCl+qemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb D30lsdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNzN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnhTXhR5wqJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed NpENrX6J9tABKnhkjizytSKeGXLzEO9k/seDlHhiXV6UkZoJlB9Tpa+CRF9U1ws67USPF/lq 352+pT5fdzp/QtHNdA7dE6ML2K41z2MGDx2V2pUCDa/YE8SjnwQs3Mkf8IDN/DQu1+8HJ1ou WZbG9l
- Ironport-sdr: 0ye4teCl4pYXgdahYzoaZL/J1BE4AjzysmXW1fUgQc5Rv9lvHev6KspxH3Mp7EZ5xfB6Qd78F1 Iv3mKTnOS7XPpW3wZ3UFmRzMLKQxA2n85My1y6D0/UjeJdaj+orRQCSKvvdtaDoiw5CnQCWvkm xmlVWRZDaXJzLvbXQGeKaPGW/iaS0VnsR2vTzIpq5sR5Zm3TQTkRlDxTYN3nZc6qQZyTU6M1xS 7Ffz/RT5pBxozyWqr4nlkTayOjMjJhqJ21cumQ+yeVnlm1OBjZbHO5nZxSXnVq+LRB7hYbki7o ey1qYH91X2DsY76u2YynqOMU
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Nov 04, 2021 at 01:17:53PM +0100, Jan Beulich wrote:
> On 04.11.2021 11:48, Andrew Cooper wrote:
> > If your answer is "well actually, we didn't mean to say 'if a GSI is
> > mapped' in the comment, and here's a different predicate which actually
> > inspects the state of a dpci object for validity", then fine - that
> > will shut the compiler up because you're no longer checking for the
> > NULLness of a pointer to a sub-object of a non-NULL pointer, but that's
> > a bugfix which needs backporting several releases too.
> >
> > The current logic is not correct, and does not become correct by trying
> > pass blame to the compiler.
>
> I have yet to understand in which way you deem the current logic to not
> be correct. I'm sorry for being dense.
>
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102967 is the GCC bug, but
> > the result of it was them persuading me that the diagnostic was
> > legitimate, even if currently expressed badly. They've agreed to fix
> > how it is expressed, but I doubt you'll persuade them that the trigger
> > for the diagnostic in the first place was wrong.
>
> Well, thanks for the pointer in any event. I've commented there as well.
Did we get any resolution out of this?
It would be good IMO if we could build out of the box with GCC 12
instead of having to backport fixes later on.
Regards, Roger.
|
