[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 4 Nov 2021 16:34:23 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=INVcWkniTwhLZ9RP2WZneuVnVIWET/vgVHQxaeEyGYQ=; b=MFGb4moi26WtOWOxDw1nypnhhyUV50ggvMr3OWnARVx2rgj/09QH/+0F0UWOKHxMn6EF9TAF+JWkMEVjvKCWwmzlC+m538hVn5ikAps7shdgu2TReU3LmUI+7Rnp2OiNI/EaV4DXUCkasDVx46XigY1ewiuvwK6oigPdylyx6PIX5uEX97jgvcnLIVBKSxOzG8OOW+4RR25HaUpgr4G2qYi8PbIq7w3AcooxlMWcn7J5Wc0V6ZPpDGUak8YicKvs7p+y0jDnM1OZhE1ZDzVulx7Je9mWdQNbaosyMVDVBtRDqFTP+MycEe7UvZlpYqGcbDuOYXTRYyaK8v0ZYPF2Dg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JCT8slFRzH+xoXQ8nxGHglK4wfqAHu+yo8bQEUyrfy9PztjJ5ugiEfm0RoKJh7rAHeFyDj9g1FxLsb9eu1rq1q4G7wzArlGsyBN3gsA3gHQNxFMcubk4fVmyVdBE4RESAOVoCM53LP4PIdC50C8bV34sEnsohDspwV2XRdjFa8r9DJ+Ece6a1GUG0HydPBoUt9gVndbYElm3Mpn9kyLuSaOsaCsnabz+TNTHLTKNFm54MAZ4I9dOshshs69yU5YzjxZXOSNaFlCXswuHBi+hXChUJwsoY/+meJPyTRbJgC/A5z9fK/E99exPhZ/492NMz31WFJLfx6jGkmmFehXAQw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • Delivery-date: Thu, 04 Nov 2021 15:34:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04.11.2021 16:24, Roger Pau Monné wrote:
> It might be appropriate to switch pirq_dpci to:
> 
> #define pirq_dpci(d, pirq) \
>     ((is_hvm_domain(d) && (pirq)) ? &(pirq)->arch.hvm.dpci : NULL)

I don't see how this would help suppress the warning.

> Or to an inline helper.

I expect it's a macro because an inline function would cause header
dependency issues. Plus both that or any other attempt to leverage
some means to circumvent gcc recognizing the pattern is only going
to help until they further enhance their recognition.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.