[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN][RFC PATCH v2 09/12] xen/arm: Implement device tree node addition functionalities


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Vikram Garhwal <fnuv@xxxxxxxxxx>
  • Date: Tue, 9 Nov 2021 17:55:53 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/PV7oXT7nesgfZXjBforPRVFb84xbxPDNzHzQp72ME=; b=RSCOA5GKryvUiA/7jesq2c8ox0qAwVnwWuZWka/RfA81roLzuX1Wb2fLnDHiG1eII7lf4g2EE/40NF1EiiOlrPxpQ8ZyYxwGLBpjvlogIwwp2qLcMp8cnJQupKZ5Bj+Ltoq8iZvCdiEeU1aEy9jdQ/idIQwicANw+lhnvYrj+OyvRpY27BBIsqvz/eM6q/NJ6ar1er8GkdOsQKBAv64DXB6/k3MEEduJoHy1CH194NVlI/I0zCZBGRPYLGdOiAW/6kXpwjN+Kud+AKIVVoTshdDkktwjxQjr6yBdqH9V2G1Y5/a/m5tMUuI6jtAaOg4CEDtRBPZh8KQWEmPXh9sbdw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OobK2T7Jo+VD5DdsMnIavqLKdaoZFIFkFrF2Uvi4vmsNLAbUvgdWqY8cy53mxZKcUVJuA2XAQHiX3hElpMUwcMQEG9IcbJ+5/RAazifAEuBPZ57KQ0UVWxtASvTWQGovFYdGMCN6lARa2jNoQK0D9A1bXkd3wC8aLmU7aKZJ3ssHtE7KyiKV+rGuT3VNunWXJREcluYVkaZleZfShe5tdxivsZTP59UFMb0Ydc/6HcEDMWe/xrSPLU+d7cVIQ0KawZuErKAvshoT3W+jtumE2una5WDkTH0Ifc55Mt/pa9iwNLwDnyAgAvl1yqoHCjuPYyB+OTncchpdHf0ysW8d3g==
  • Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=xilinx.com;
  • Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "bertrand.marquis@xxxxxxx" <bertrand.marquis@xxxxxxx>, "volodymyr_babchuk@xxxxxxxx" <volodymyr_babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 10 Nov 2021 05:06:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Suggested_attachment_session_id: ef0d14d4-0b7e-7a0f-abd1-53d2e8890cef
  • Thread-index: AQHX1TfQHzriIwSLBUOZInYGWc/AK6v7DOyAgABtxzg=
  • Thread-topic: [XEN][RFC PATCH v2 09/12] xen/arm: Implement device tree node addition functionalities

Hi Jan,
Thanks for reviewing the patches.
Yeah, I messed it up while breaking the code into multiple patches. For next v3 patch series, I will move the function call "handle_add_overlay_nodes()"(in patch 8/12) to 9/12 patch.

Thanks,
Vikram

From: Jan Beulich <jbeulich@xxxxxxxx>
Sent: Tuesday, November 9, 2021 3:19 AM
To: Vikram Garhwal <fnuv@xxxxxxxxxx>
Cc: sstabellini@xxxxxxxxxx <sstabellini@xxxxxxxxxx>; julien@xxxxxxx <julien@xxxxxxx>; bertrand.marquis@xxxxxxx <bertrand.marquis@xxxxxxx>; volodymyr_babchuk@xxxxxxxx <volodymyr_babchuk@xxxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; George Dunlap <george.dunlap@xxxxxxxxxx>; Ian Jackson <iwj@xxxxxxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx <xen-devel@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [XEN][RFC PATCH v2 09/12] xen/arm: Implement device tree node addition functionalities
 
On 09.11.2021 08:02, Vikram Garhwal wrote:
> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> @@ -331,6 +331,205 @@ out:
>      spin_unlock(&overlay_lock);
>      return rc;
>  }
> +
> +/*
> + * Adds device tree nodes under target node.
> + * We use dt_host_new to unflatten the updated device_tree_flattened. This is
> + * done to avoid the removal of device_tree generation, iomem regions mapping to
> + * hardware domain done by handle_node().
> + */
> +static long handle_add_overlay_nodes(void *overlay_fdt,
> +                                     uint32_t overlay_fdt_size)

You adding a static function here without any caller got me puzzled.
First I thought you'd be introducing a build failure this was, but
it's really patch 8 which does by introducing a call to this function
without the function actually being there.

Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.