[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][RFC PATCH v2 09/12] xen/arm: Implement device tree node addition functionalities
- To: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 9 Nov 2021 12:19:37 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cfPhLruYjOCa3U8YgYc0tA4C4vvSxTnDRem1yOKuIjk=; b=O23I+Ufus2xAveOr8+hERcwRr4RygIsDMoSxM4+FQGj+Xd6e7a0/Cy8VlXYetp+oS8QvfRsAp5nc672imxkHl2gVdvOa04NibNXlH0Vwfrae+DbszPXmHb/h0NN0dJi46ebJb09nUc9ob7N2JG+q9Ud13Q4Pvg0jTEiqUKtV6wlwM1ugmc8xg13NGGQ4vqO7rZXQkNvTGsid8j+Jvbkz5bxo4XTpAM8qkw5WuWLbjFy09Rkc4dVBALXkVtON2aQzzClUzNRhW5JzVqO0kkAYG3nbvefxOTxqenKCdqpWA3r7tYp/U2gFmCCtQr57or80vXyOYfvuUoaYZ/ibXKZw1g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jpQCMQRs0q3JeXPtLeYrdNdeC6W0fd9JxrfqUhaMYS5aindeRh47t5ICFspZM57z6t51Za+XGmRWfc/wIhazDG4eHfXt4rRqC4phIDp9RjviJD6kiTEn6azNjOaKPA3u++ZJIP3YVlukULI+svbQP+akIGvY5BrFyhvGdom96asLmocLEdyo9ZPc+cEMBEmDgc6FEjuXdRedfMd0KVNqyhVHd1YuU0iJDYS8NzWByE1fbw5wKwh0X4Kxy89NFfhNR+VFJl0sYFsqRnagXrJChlBwnJQMFQ8zT2VA+9NA46fl/eThql6pvXY/gLfhkJ7Fc3OYXLklOx3L8Nom+DxxsQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, julien@xxxxxxx, bertrand.marquis@xxxxxxx, volodymyr_babchuk@xxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 09 Nov 2021 11:19:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.11.2021 08:02, Vikram Garhwal wrote:
> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> @@ -331,6 +331,205 @@ out:
> spin_unlock(&overlay_lock);
> return rc;
> }
> +
> +/*
> + * Adds device tree nodes under target node.
> + * We use dt_host_new to unflatten the updated device_tree_flattened. This is
> + * done to avoid the removal of device_tree generation, iomem regions
> mapping to
> + * hardware domain done by handle_node().
> + */
> +static long handle_add_overlay_nodes(void *overlay_fdt,
> + uint32_t overlay_fdt_size)
You adding a static function here without any caller got me puzzled.
First I thought you'd be introducing a build failure this was, but
it's really patch 8 which does by introducing a call to this function
without the function actually being there.
Jan
|
