[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.16 v5] gnttab: allow setting max version per-domain
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 4 Nov 2021 10:28:51 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KE8DEev9toGOWwWTKUArAZjTU0VFhGpTM+F7KvHF0ZE=; b=RsXOi02xiEKLKOM2QHwIEE2mVjE8br/IciByK7StTPRaQc9s0a/z73UMdPmQxNQVdv5xzdRXXBpcf2utz/kR68hLw9kLUmvyZQnwsEhhQ4BAdCjTwNAz4A12ivUF4Ndax4Vcz64LnOD5aQLJfFY/jRC4n7KlEGsOI1wmaYf5o1hAKfDoRrjRlSR/7lYrAni56YkOlvCNkxia41RqZ5egVpsdw7KV6syG+dsL0sZTrMNrbSjc8jksd47s5++4BPjnxL8irficTBEm26OnGD7e7ch0LCy6EX29hs6B/teIpx8o/0kUEE+ZweK4keXNkKHpdXj9q/57iH5pMIvpfoUi9g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kWQPFL86FWLZihKZrccVusQBOtYgZT6w0v44JMISbK4xLQD1e168mG2gxgoetR+6K01xSN8DybWjsFt9iiiH+CvDCGkJJ/LedNag/mPwrxNK3wHygJONS2uXRoI3dlfFXiRkbuWahEV2g04DlHPRB7JXtB0zCRgm7030FeJe0NjG6fBcojPtfUvkGu2mWT9sdydAr/EB9iIbXGd7iLFW3m7Ofr2lXl5l2GVCm35LxMt/TwNsnQAz+apbG+upPytWOvRycDYhaFfKudf/qpeAZTlWhooVCUHCXv5mEmZ0F0SIpIUsJDLkQXqLnJgoqI5qz3Amh/OFXkICyqidPBD37w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 04 Nov 2021 09:29:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.11.2021 10:16, Roger Pau Monné wrote:
> On Thu, Nov 04, 2021 at 09:55:03AM +0100, Jan Beulich wrote:
>> On 03.11.2021 15:57, Roger Pau Monne wrote:
>>> @@ -69,7 +69,8 @@ int gnttab_acquire_resource(
>>>
>>> static inline int grant_table_init(struct domain *d,
>>> int max_grant_frames,
>>> - int max_maptrack_frames)
>>> + int max_maptrack_frames,
>>> + unsigned int options)
>>> {
>>> return 0;
>>> }
>>
>> While arbitrary table size requests may be okay to ignore here, I'm
>> unsure about the max-version: Requesting v3 is surely an error in any
>> event; I'd even be inclined to suggest requesting v1 or v2 is as
>> well. Adding such a check here looks like it would be compatible with
>> all the other adjustments you're making.
>
> I think if the grant table is disabled at build time we should only
> accept version 0 as valid here.
IOW "options" as a whole then wants to be checked against zero.
Jan
|
