[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] xen/arm: call vpci_add_handlers on x86
- To: Bertrand Marquis <bertrand.marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Oct 2021 14:29:03 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GomsQYhB9niBvPCzJFh9+N2L5TTVA9yHOWBNKFQVnq0=; b=KH4/WtaxsLfz6p1SLLtu1IlDg3Sq2U/gu8xLOkQCps1w2Ar4LrJZv7EcN4LyJ7H+6FLeaF2gJMDM+qRtB7ATlXM6+B2ubG5Mmje1B//HzAR3n0yZCVYl66MP6Ueoc600e3UZREihL6CNKVTn7inK0V+SIrQ1Sk6rkrcDdKCqPG9IA7UAakbcHIY/uxgf15WatYFeZPVRuDrhgt9WltogXx1VED1QSmOp5AGJtNn8ivwtOxYwAP8z2MwwsyyDLole45VXA4Z+r0PUFYprE3rAFVW0e1bTvaKxAU1MQybFwkfhr+UmsGIPZSkh5JA9qfviQy0rBkox6tStdRQR8jhfvw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EIQWSyHsnWXezHx6blFmeD9dlFyvgOCdo3nGv3aQPgFghJkNDuk0oUak8bxnBCXU4y1hJU/qEOMA0B/WxUxN8sNSbMofi1k4l2QYBoW87pudsxudRXbxdWQiXCadE5WxWUY19XTuGVC4k9a7Hqu2/OT7HMrwh7sRWhUe2vYM+DIAgQmuVy0eIP6Bt8hGAZGOMpqQz/iq4v7n8sDuEbQD0RS73crvNTan9tXQ7679mM8N3ZrYZ0zPXUkmwPtPKW42kvldcISwxNn328Ynsf3WYNqauU2Z/Z0KEVgPfYuuPDVOv8l1+goAuPbw3HEbdsawxFHlD2dYK+p32AY3ZojZFQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: iwj@xxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, Oleksandr_Andrushchenko@xxxxxxxx, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Oct 2021 12:29:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.10.2021 12:40, Bertrand Marquis wrote:
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -756,11 +756,6 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> if ( !pdev->domain )
> {
> pdev->domain = hardware_domain;
> -#ifdef CONFIG_ARM
> - /*
> - * On ARM PCI devices discovery will be done by Dom0. Add vpci
> handler
> - * when Dom0 inform XEN to add the PCI devices in XEN.
> - */
> ret = vpci_add_handlers(pdev);
I think it wouldn't hurt to retain a (re-worded) comment here, maybe
along the lines of "For devices not discovered by Xen during boot,
add vPCI handlers when Dom0 first informs Xen about such devices."
Jan
|
