[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
- To: Bertrand Marquis <bertrand.marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Oct 2021 14:26:35 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7fFu0Ope6IWazlryDmobnN2CzT23uN7rbeJ2sMJC6HA=; b=Po5mbmHgaJjAh5EY9SH9Ipkig9GTTjGAo1XWoPMDi6NkgcEGpVHmiFOlEyk/tTcvb7D6kYNIgc2d9xfnk03xUuRa5EzUatGXkRnc/YD579kii2G6FxVNYhtIGol8lJpa+Aov0Hc7+6/88oBa4QQl742rN7/izNWAq8rwxdSUwVpBSQ2XuKGB3JcMu54sY1ZCnGJBpZPSMQo8bVfe74/FD4VoBcw5sFwC5b0uDGxf//vRqvX+id6xRxzOXWSkbkHN7q1dJWzM+G4V1uGXUm/DFEQ6AZex2bP/Zn08PZkhq98UedrOW89GXFhx1aO1wScmroNdfhM4ZZnYm46UIFDZkQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P/bEVVMFBl8dd1iGe7b9dPoSdmTuihjvcBPvkyI4jDPI9VDKe0uPUEakVMnZeNSgaiRescvJR3NUOQDXotfJ75itzGXTkFSVwQ0doc5Gwuh1LbwZ06cF4G5o0jjpnj856QQDmDScvoUuVxV67zCPsKn198SOsMvKn2iQYpS4QcTYYhwTNpMeCYw7bJrdn5X3ihlBrCv77cY9Zm70eBvWEZgiLPW0WDmPVYf+YKI2ayK31Kd6UUhRB++GR5Lrstr2Xj9Xj4GofsaiNURXyZ4xg+7iCLSqB257637sc3EHgrXCg0Gu3hmyjbuoPACFXsKSDd7LUZqc0qG9mTtl9v12EQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: iwj@xxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, Oleksandr_Andrushchenko@xxxxxxxx, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Oct 2021 12:26:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.10.2021 12:40, Bertrand Marquis wrote:
> This patch serie is a follow-up after various findings on d59168dc05
> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
> agreed in [1].
>
> It does the following:
> - enable vpci_add_handlers on x86 and not only on arm
> - remove __hwdom_init flag for vpci_add_handlers
> - add missing vpci handler cleanup in error path during pci_device_add
> and pci_device_remove
>
> [1] https://marc.info/?l=xen-devel&m=163455502020100&w=2
>
> Bertrand Marquis (3):
> xen/arm: call vpci_add_handlers on x86
> xen/vpci: Remove __hwdom_init for vpci_add_handlers
> xen/pci: Add missing vpci handler cleanup
Imo all three changes need to be in a single patch. An option might be
to have first what is now patch 3, with CONFIG_ARM conditionals, which
the subsequent patch would then delete. But what is now patch 1 cannot
come before patch 2, and patch 2 alone would unduly impact x86 by
moving code from .init.text to .text for no reason. (Still it could
technically be done that way.)
But let me also comment patches 1 and 2 individually (patch 3 looks
okay, apart from the ordering issue).
Jan
|
