[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/17] xen/arm: solve compilation error on ARM with ACPI && HAS_PCI
- To: Rahul Singh <rahul.singh@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 29 Sep 2021 10:24:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xYLDlTKQG/veH3t6BApJ/5eZwO8H4btcFF9540vj7no=; b=bee6KJmrc0V849gs2cEh3G/naaUj6Lk/8fLJL+U08htNDaF2LCKj6GmpQw4TjGwkjZsVVCR+qcJOFWN8+Qpb5MbE2f96L6Ns5C/apMA6XZtKLkV0q3Ye23v5dEJZqoFHwbMfl2+3lQYdStF9LWPPIc/CDO63MmA0N3mhD8Cf7E72JXKVmnmwJxNPbuxfSAY9KX/fpC6F9ZPAFmvlhbIRsgRyxC5fMpEd8j3eMGmuELNhRA/0i2eMuZL1JELv2dnRAncie0SM6vVZpuwfD4OtSs7Bxfuc8sSFOZkNqeyklfu27bYJ55vYKGGlO3gPrvtOL01sDAaZPAB0f7J9oJ/yAg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JdNWJb5YoOLW2QNKqjzoIxtFagHVNWIg9TRjjNPbtoXI2aHjFxz4k3Gqa7bsWHshj077ZQ4jTdvN4tRuRYtJPUX+q/mEGn7VARRJdjSNqW9pfKb9iTsSVemwxYL8RIIV7cwhNzSIk7uNOgXlgOrzmn+vtvQCRLog9P6S7XId5eHQYJk9RKPY0uDVFYC/OHF0Qvbnrkqc/TjlblCV5JrkMPmcrdA9lU6TlVDNKpcqTXgIFD+swutRn4dUURU/xcaIh9BmWpnztnB0lzyaPZfu09X5FcDcB1wDqlOgsNob05UjDCoBPrLYvZ9NmrWX9tof4hYEEG0BwncBVYkb+hp23w==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: bertrand.marquis@xxxxxxx, Andre.Przywara@xxxxxxx, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 29 Sep 2021 08:24:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.09.2021 20:18, Rahul Singh wrote:
> prelink.o: In function `pcie_aer_get_firmware_first’:
> drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse'
>
> Compilation error is observed when ACPI and HAS_PCI is enabled for ARM
> architecture. APEI not supported on ARM yet move the code under
> CONFIG_X86 flag to gate the code for ARM.
Like iirc Julien has pointed out for another, similarly titled patch,
"solve compilation error" doesn't really seem appropriate here, as
with the tree at this point of the series no such error should be
observable. Unless I'm overlooking something.
I'd like to suggest that when you receive review comments, you apply
them throughout the series. If you follow the approach take in the
other patch ...
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
