[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/17] xen/arm: solve compilation error on ARM with ACPI && HAS_PCI
- To: Rahul Singh <Rahul.Singh@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 29 Sep 2021 07:29:14 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9pHI4/IPOhsGJdfgmEp9Vt1QPCN0cKeOB0pTCObUcCA=; b=Nwx1GFp8UVAM22rKkA+P/BgztUw5rM8dSm6X0tZWuZs6pGDcYYAF8NKOV/5P20ctN2VEACDrex9Rd5kRLMVCjUHR8fhR5XgMAatvrpxoq+BsbAcnyo9FSVPXoDwmKrrpoH9+QMEcMsrONG1Gb+ru3SSTOvC7kd8QhizgZlMrkhp3F4mjQ2DIZeY1iWhIDET1FlCARPWQK6pi75bpgHKcET/lyrjkuPvVJyv6chlAgGDTDAv0A91Gv+fWnnbnhLJEDLHy130gb7LSX3eNO2CZZ57Z0Gf2RNk4QgBLYYYztsKPnw+0qEbiGxsgmpcM1qoy7qYIOo2U9nGKiXSKu4Avng==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RmmV5hfMI3sTO98+md0MUoWinu7Nil/iulIhHFxsfq2MddNTXknUKUq0mZOLFFPpYJanttkv+lvy61w5MTGkjo/ZWxnZFfTE8P2D3LlNAhs5oVKx57K/Q33sIAjKljay6Jg9t7AeiY04wg5yes0KbouKemD0JdAPv0qw4uD0Y6Y05uXyVeJo1itmW0cqYBmZ0MdQFcmiC53NtfYOS0tfEjJ6Vt1grAmjsLRPi4zLEw6CfbLk7Y8oMqrNNMPRYhMAi7PBsGIT05gmHHn+ZQjEw1ZCqqcKmdgQMvt1Q9kRI/IHYtyTHpmSrCK7CuzLwTbrB3IKxNeJMrOVzlJvHIPzFA==
- Authentication-results-original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Wed, 29 Sep 2021 07:29:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXtJV6dalQJX/UXEa/GQQbUgx/4qu6njuA
- Thread-topic: [PATCH v3 03/17] xen/arm: solve compilation error on ARM with ACPI && HAS_PCI
Hi Rahul,
> On 28 Sep 2021, at 19:18, Rahul Singh <rahul.singh@xxxxxxx> wrote:
>
> prelink.o: In function `pcie_aer_get_firmware_first’:
> drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse'
>
> Compilation error is observed when ACPI and HAS_PCI is enabled for ARM
> architecture. APEI not supported on ARM yet move the code under
> CONFIG_X86 flag to gate the code for ARM.
>
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> Change in v3: Added Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Change in v2: Add in code comment "APEI not supported on ARM yet"
> ---
> xen/drivers/passthrough/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 8996403161..d774a6154e 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -1150,7 +1150,8 @@ void __hwdom_init setup_hwdom_pci_devices(
> pcidevs_unlock();
> }
>
> -#ifdef CONFIG_ACPI
> +/* APEI not supported on ARM yet. */
> +#if defined(CONFIG_ACPI) && defined(CONFIG_X86)
> #include <acpi/acpi.h>
> #include <acpi/apei.h>
>
> --
> 2.17.1
>
|
