[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/11] xen/arm: Mark device as PCI while creating one
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Mon, 27 Sep 2021 10:04:33 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gPYe77LdkDEmNrinKE2WVBUO6bpsOy5UdR7i9kPst/4=; b=CnpyjtaufdKACAS2M56cdjlFZjd37C1CJaiGN4QJuqllLaSsQlSLed4uQCD9ImNDRhnCpLdfuW/pUVEhSZ5UEz/C9odHkvjG5empW55xWSaIV6HCPIQcFrLx35Rzc/EiuVcLXCKvj7APk/TX+N4okB/u5kLVYmJEhBGwnmyyr2J+pMa1KA+ORt2F+ZshHeJLStRKJ/tjO/AZBV+nAmFHUYUws+zZBEeifV+QvtydvqCl/8VxVPZHfjcxUIp8Z/1GNu5YxchYpmop8l5iI8fun1yIVE9WqXxsiY6Sl9FV5hUUBPs6fjq1dKU4/+quANbdaa1YmFoxML/PdYvO6ml1kA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CErWoN0gcqYMvW8iaX/sBLW3GSu19hkHKT9IcFOYoAQWGKNHiKEgblFzYNnyFLPJLi/KOIrw2bFoY2TAN6IFzRBJXmsgj5cVZ2+7QSM3Y0zPBFqjGg6F8JjDZSkUoUpYfuzG1HrONc9lt2NQDu4hUj++ptp+2bg3zLPtdd1OK2+jOXHpqSJ0LOYnaLM0qthPe+TcpcI1AXPFXk7N1TCUmsLIWHIb9GzeKR3CuWLqiJIbxLhLf7OYZ72zE1OcmCy8UButgQ0n6501vNjLoMmN6bXyLzkwBASbYI4rIx+NYftSqYFTvui4Pmgs8Wau0f60oYR/HI+IIg1dW4PmpoKVMQ==
- Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 27 Sep 2021 10:04:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXsHoyHtx3VKSfZEKPQekyrs7GEau3hnIAgAAQrICAAAldgIAABLUAgAAG9wCAAAEGAA==
- Thread-topic: [PATCH v2 05/11] xen/arm: Mark device as PCI while creating one
On 27.09.21 13:00, Jan Beulich wrote:
> On 27.09.2021 11:35, Oleksandr Andrushchenko wrote:
>> On 27.09.21 12:19, Jan Beulich wrote:
>>> On 27.09.2021 10:45, Oleksandr Andrushchenko wrote:
>>>> On 27.09.21 10:45, Jan Beulich wrote:
>>>>> On 23.09.2021 14:54, Oleksandr Andrushchenko wrote:
>>>>>> --- a/xen/drivers/passthrough/pci.c
>>>>>> +++ b/xen/drivers/passthrough/pci.c
>>>>>> @@ -328,6 +328,9 @@ static struct pci_dev *alloc_pdev(struct pci_seg
>>>>>> *pseg, u8 bus, u8 devfn)
>>>>>> *((u8*) &pdev->bus) = bus;
>>>>>> *((u8*) &pdev->devfn) = devfn;
>>>>>> pdev->domain = NULL;
>>>>>> +#ifdef CONFIG_ARM
>>>>>> + pci_to_dev(pdev)->type = DEV_PCI;
>>>>>> +#endif
>>>>> I have to admit that I'm not happy about new CONFIG_<arch> conditionals
>>>>> here. I'd prefer to see this done by a new arch helper, unless there are
>>>>> obstacles I'm overlooking.
>>>> Do you mean something like arch_pci_alloc_pdev(dev)?
>>> I'd recommend against "alloc" in its name; "new" instead maybe?
>> I am fine with arch_pci_new_pdev, but arch prefix points to the fact that
>> this is just an architecture specific part of the pdev allocation rather than
>> actual pdev allocation itself, so with this respect arch_pci_alloc_pdev seems
>> more natural to me.
> The bulk of the function is about populating the just allocated struct.
> There's no arch-specific part of the allocation (so far, leaving aside
> MSI-X), you only want and arch-specific part of the initialization. I
> would agree with "alloc" in the name if further allocation was to
> happen there.
Hm, then arch_pci_init_pdev sounds more reasonable
> Jan
>
|
