[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/11] xen/arm: Mark device as PCI while creating one


  • To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 27 Sep 2021 09:45:54 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AwNwRqoEtd1Tv6Fa40/+aQ9YyaXVlHlq/LvEhc6yWpU=; b=nRsFXQGh0PwUZsQj8No+xtZH5XOuJz/o5etfwmKERs/XlXib5L7JlbO0WgM/SLjQUYZN0/D84iLeDwvLrjlmSjBA0u2eePVMcefbAmaHtijDCYPbFRRaEk/PViuRnBDN4Nhou4GRmvYkjyoKVnPA92y0y4e5exW/CycOd7hX8A7CdsOLD5wUXaYxpjAhxj1k4QrHw4SOf64hSzGz09qrJ3kRJWSjg9IvIqeDTpz4Wc4BIzW9KfIWxopRwvy6aOYn1cJqYu+ky3jjRgo+AqXz6YAbDTjO5Saxpi0N5xes9reblCySvwpxCjnV+srH0r4UQ04E5H2J966yH7IgQlk0BQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P0lfuZ29sJCzQbucmKptyVTdCraY0tHr8fgK9KBYOJOdkC8T7p2bUa4gs9Sqz95FOhe2/qcuC0U3WjheZ96KqDRpf9WJRNZFKSehyhzz8R3NJsiu7qPjF+ZSy0cR43K6ZMjp5TQETaaH2k3dSDyxz2GnHWgJ2pefZIJ3/ShoRj6Aq02gvRrTDQfjn47JuNkNupl9+7gcArptKiRETTmww42jVtVsJ6E7rC62bm8bw+UV3lEY6/w2LSwFIm6cFMMTxlIqnK6FTnMxsLPpI0TyPOgYYaYRv8KW1dyNgfQxpmZJ2Y6AAVP7eerIiPNYQHL+KdUdQRdg9fwEQYz1LplNZg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: julien@xxxxxxx, sstabellini@xxxxxxxxxx, oleksandr_tyshchenko@xxxxxxxx, volodymyr_babchuk@xxxxxxxx, Artem_Mygaiev@xxxxxxxx, roger.pau@xxxxxxxxxx, bertrand.marquis@xxxxxxx, rahul.singh@xxxxxxx, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 27 Sep 2021 07:46:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.09.2021 14:54, Oleksandr Andrushchenko wrote:
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -328,6 +328,9 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, 
> u8 bus, u8 devfn)
>      *((u8*) &pdev->bus) = bus;
>      *((u8*) &pdev->devfn) = devfn;
>      pdev->domain = NULL;
> +#ifdef CONFIG_ARM
> +    pci_to_dev(pdev)->type = DEV_PCI;
> +#endif

I have to admit that I'm not happy about new CONFIG_<arch> conditionals
here. I'd prefer to see this done by a new arch helper, unless there are
obstacles I'm overlooking.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.