[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/2] xen-pciback: prepare for the split for stub and PV


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Thu, 23 Sep 2021 11:13:31 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bmH2R3i2RP4dHzfHu0s3hjen1sJwkocnlF0NpX9KS3U=; b=bTXRt/Yn1P3/zxPynK7G3HSFruDhiBZyyIZNioSBsBs9Z6Yr8QmRTibOFkBtX02J9IbAe9oMcG26In+zbyB1rcCjs6OXs6dHth/PHF5pr/xke+0bpThEhMyuCZ8wy6YDqoRpXuC1ZCfslp/GO8yWIho1yy3RqFyjnD0NPvCdonk6voOVr6YtLxEXr1oQ9ur/SeNBXw5mJ2t5zQa4kaEADIU3vCcnFtXOJ8+xWKX0voQW4pxZD9XkyMg/brg32TI5NeeYqFL3ewAP+bRaY7GcRg57SRzMa9ODoYpjbqiaoHtNQszp1FPXio8zJafkS0AWfIQhDsuVVSau2CmWbzxONA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dfcAZxsSdMPBBvFzpvCmDiR3U/RbP3XiWoPB2UOtThnaqG8UA2iY+J1xnV0gfWrBV4qMS86KHDMumVEUC6JBG2J8Lfnr8mxqkAxJ4cLRE3dKP6rbDDyoZuJOK/mVvBDRUIeesecE/59pRbgbOaR6+nPnjWx+oeU+QlAPQMYO1zyrvN+dnjxKVYrvgWW8XtI+aK/LHmjgqaqTG2feUIB9v0DwvxJDRfLHPfIxgJSyLZa85h+bRlopGQ6mGx9BkSds1vn1JiOODdYoAQQ7jhkPG/3AIiUfAJotTeo4FiOuw33/GK7nMZUzoe9F+Xtz2LnOlCY3EqtQ1jLrNVBNAVmp+Q==
  • Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
  • Cc: "boris.ostrovsky@xxxxxxxxxx" <boris.ostrovsky@xxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 23 Sep 2021 11:13:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXsGDshY1QGXQ13Ui5WskBVnVMCauxdpMAgAAAwIA=
  • Thread-topic: [PATCH v3 1/2] xen-pciback: prepare for the split for stub and PV

On 23.09.21 14:10, Jan Beulich wrote:
> On 23.09.2021 11:53, Oleksandr Andrushchenko wrote:
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -180,10 +180,34 @@ config SWIOTLB_XEN
>>      select DMA_OPS
>>      select SWIOTLB
>>   
>> +config XEN_PCI_STUB
>> +    bool
>> +
>> +config XEN_PCIDEV_STUB
>> +    tristate "Xen PCI-device stub driver"
>> +    depends on PCI && !X86 && XEN
>> +    depends on XEN_BACKEND
>> +    select XEN_PCI_STUB
>> +    default m
>> +    help
>> +      The PCI device stub driver provides limited version of the PCI
>> +      device backend driver without para-virtualized support for guests.
>> +      If you select this to be a module, you will need to make sure no
>> +      other driver has bound to the device(s) you want to make visible to
>> +      other guests.
>> +
>> +      The "hide" parameter (only applicable if backend driver is compiled
>> +      into the kernel) allows you to bind the PCI devices to this module
>> +      from the default device drivers. The argument is the list of PCI BDFs:
>> +      xen-pciback.hide=(03:00.0)(04:00.0)
>> +
>> +      If in doubt, say m.
>> +
>>   config XEN_PCIDEV_BACKEND
>>      tristate "Xen PCI-device backend driver"
>>      depends on PCI && X86 && XEN
>>      depends on XEN_BACKEND
>> +    select XEN_PCI_STUB
> Does kconfig not at least warn about this? The selected item has a
> "depends on !X88" conflicting with the "depends on X86" here.

Why?

XEN_PCIDEV_STUB depends on PCI && !X86 && XEN

XEN_PCI_STUB has nothing, just bool

XEN_PCIDEV_BACKEND selects XEN_PCI_STUB

>
> Jan
>

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.