[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 1/2] build: set policy filename on make command line


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 8 Sep 2021 14:20:08 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJNVwzYym6eiXmkVEWFw5XalOdBRLFERy32pUmqqaKU=; b=IYHghuzRF7ohVhDMS6BzBOVovru3ucv3V2iGjNGyfoK/fK07Yhx+yn+b3nMMdZvIM1X/1yPYkrLjUrCmYnBv6HW5ed/fEfPo59UKliCV1jSEBIbtCJMO+8DSGg4YVfOR7WyTJjBHbPebT4XzIrxHxv1rSqWWPnohfq8PyU24yzWi/Yb3bGkV1yHH0PTRfHVV1DYfebTO2bfw9afqI5OxD9u7pqI9MFu1NzB++8eTPje0Ao75to1MgGvunoh6wpRhECFnZ+AGgZWNeq4EJnAOgXmNqwd0bIuyJFwyr76N9NkTuv5mzNMP2wXYEwNlcIa4sG2aLd+VBnxmxl3DPtQB6w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dGcJX8fOZTqIRSx688p3aB7ULkkl6DZ7fJbWlSj1zyODk99N2TzCcwka5Mnd0XN7uasKr+76r58shHYSgTY9Hqszs7SrnkYW8XWzy9WFkRkLQdLesNbeIGnGJgYnGp/DLbfbusBO8HfqaCfn6pTuNsuMaVlPnLkpfIIZFdOlnNQsjUypJptwcOKMrG4ywh1kA7NguD6OmA1L2hRCcFAKtcE99XnLB/MrFwBQSat4/hFXV3FQopkIItNl3V03UO+/VKUFT5mVsKnBhGdarVYNhrEd3zL53inxi08MCDwb5zrhAnirr3ILd767pRJJoZt3rT7lZ/P1V24RHUA9gtF45w==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 08 Sep 2021 12:20:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08.09.2021 11:54, Anthony PERARD wrote:
> In order to avoid flask/Makefile.common calling `make xenversion`, we
> override POLICY_FILENAME with the value we are going to use anyway.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

> --- a/xen/xsm/flask/Makefile
> +++ b/xen/xsm/flask/Makefile
> @@ -42,7 +42,7 @@ FLASK_BUILD_DIR := $(CURDIR)
>  POLICY_SRC := $(FLASK_BUILD_DIR)/xenpolicy-$(XEN_FULLVERSION)
>  
>  policy.bin: FORCE
> -     $(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common -C 
> $(XEN_ROOT)/tools/flask/policy FLASK_BUILD_DIR=$(FLASK_BUILD_DIR)
> +     $(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common -C 
> $(XEN_ROOT)/tools/flask/policy FLASK_BUILD_DIR=$(FLASK_BUILD_DIR) 
> POLICY_FILENAME=$(POLICY_SRC)

I expect that you wouldn't mind me wrapping this overly long line
some, while committing?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.