[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Arm: relax iomem_access_permitted() check
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 Aug 2021 10:11:10 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hfn88W/TL+6/Kaqc5/V6BscKLs5KNXuBrQy7LXoKHGw=; b=WQUd+W8tQE+lMNBYh2yTZxlU1L6WbDLhm1f2o5KBj+30knu0l4t/jBI6f/G8ctE1OHTCcRrm7tlaXEH7qe6VOWtzioqOUpIkgNqyhwf3VR03fjZUWUCjFiSiQN5y9xroWaOFd5O5+DFUwv++VHiyLzKY4Gw6YSaJgstY0313lsXy+4KSzIzBhPVqVgP0zn6dnFN3HuTVsnC0zuOx09CV+YGjirokyva4s98Vc8RHJWWaqhlSswYItjcYnimnSTlWuALL071VEAwmK40uLFeStFKcAz6zV8PEniYptPXB/5ApdfcWJmCwb9/3f6n77lZqq+Rski/m8fBnVgk0lEhj1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OcGIjQ0wt5IJ5DMCyVNdBtChMaYQzgFF0znEidQ/5Ea11fLNWwJezs27eFEuLe51EfnhoqBbFUEh3Y48RLjQ+iISDIRM4GO/Gboc7c5/irxuCSBUJe+Ox1ijsaxt7pFBt6JfNP99OojLz1MXxwuS03Wn7ufbCLtPWDape5jdhUDgyWBIWH1bf1R1KfMQFOQ2Ak3qiOf3MpWRGNnF1ZFa7indF727qmJ8bHdRWQ58z+BkJ0PV3x04OIM90YgjpB0UYFyPV1D6SHBMRp84eILwE0J+yK5q6heOLtCYGn3vNigSD4VlVJKzhexR8ObpPCA7m5/rwswDUeuNiUDu/dcQcw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 19 Aug 2021 08:11:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.08.2021 19:44, Julien Grall wrote:
> On 18/08/2021 08:52, Jan Beulich wrote:
>> Ranges checked by iomem_access_permitted() are inclusive; to permit a
>> mapping there's no need for access to also have been granted for the
>> subsequent page.
>
> Good catch! OOI, how did you find it?
In the course of my large-IOMMU-mappings work I ended up grep-ing for
all uses of the function, and this one - while unrelated to that work -
caught my eye.
>> Fixes: 80f9c3167084 ("xen/arm: acpi: Map MMIO on fault in stage-2 page table
>> for the hardware domain")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks.
Jan
|
