[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/cet: Fix shskt manipulation error with BUGFRAME_{warn,run_fn}


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 17 Aug 2021 11:31:57 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qEcpuuY8soouLWf/Xz3iC2b8bjxwwZIJkvWqFmFlUBE=; b=lF7x+Ho89L6F3YwINGXEMPQvZvTSVFOcKZDHZExqIVuk+k/52WBy3XMV8iHy8E/OdPvO5IKcR9z5NjdRnvnIOH/QPg1ywxevjNkSdSDa3n4i7Kx79IzzBVaVUIWyr2deRsPEzLzLLdOpPMJLR07o9w3xLoIDkqZIrAUS0CY45BLNouUV21Ph2t5euD91B7PObCbmvJXVDvhKC5IFvc+nvcldH0nyayftbu8oLuMpHAGxppi1XQrb0oA6FXBDfEKo36XK6W/r0TQZaGofK2gtaF7zI5ID5iRZRnl3WEjBY0vGX0Ve/6fyCuQDqZt+kGJeHpI3unRo3/7mhm+piG6Ijg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j3J4vQJyah7lVEY4qpWh8b0Sz0NsEQdUgwwlArMynttd+NigucksfjoFxpDyruri6f167WIV1ELFon/dniQVhz0ujXR1yF2fJPnNF0DP6e5OwF11U1Uo094nzqa2A3s9UdXKfrBkLSDvEgxJv6kXPQMmZsqKg5cPWKHLPzCoSxeV8ViWuwxPRLBKoBu9JQhL3nlKPZRvNDrFvXpyTOZt84/E4nRsE2k0rFvQsIXoRD1yC/FiKJPSXGQcxLFMQ8fZ6mmBDUVj8QPgPD7siubtT+wEj3Qq3CT/9WvuUwdA4Ds1QNijkIwruR7A+MC6BpxuPxt5f17XSD+dlAR6N4WKpQ==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 17 Aug 2021 10:32:27 +0000
  • Ironport-hdrordr: A9a23:cFQX0aPuufGTY8BcT0/155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjztSWUtN4QMEtQ/exoS5PwPk80kqQFnbX5XI3SITUO3VHHEGgM1/qb/9SNIVyZygcZ79 YbT0EcMqyBMbEZt7eC3ODQKb9Jq7PmgcPY99s2jU0dKj2CA5sQnjuRYTzrcHGeKjM2YKbRWK Dsnfau8FGbCAoqh4mAdzY4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA H+4k3Ez5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z fxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72yeBsKT+56wa5JeBrQ7EQt+Ptm1r hQ4m6fv51LSTvdgSXU/bHzJlNXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP JlAKjnlbVrmGuhHjTkV1RUsZuRtixZJGbBfqFCgL3U79FupgE986NCr/Zvx0vpnfkGOup5D+ etCNUiqFgBdL5PUUrRbN1xN/dfMVa9NS4kBljiaWgPJJt3Tk4llKSHl4ndxNvaNaDgn6FC1K gobjtjxCcPkgTVeJaz4KE=
  • Ironport-sdr: yPkGe/GFo/3JeZm5QaR8rrHW4p0u2u4EBmQ+6WBhFYDB4YaODTDHDJYE4yZmOfpFXJE2D8SgFG 0xJGKhNlAZozqmsizFHyvYWxXCLNgLBBFFjrEdV+HMYbMvLSQdjXzKNw4o43y76k1TeWEQTfxv PhXYQP9mxvICM2OKxnLZrkbbflqvA11ZfHZZZ7NMdJ8W6tfS77UYh0WWPfocslGuA2FWE2tptp KCazkN+hnILa4OP9F0DLWTSeY2JMf51nLBV39utYQIUzo8AV1zqRsl4KOUohfGdfVUU1u/ejmW Gm1Af3WHrnb7zNZDOhb/Mskf
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17/08/2021 10:10, Jan Beulich wrote:
> On 12.08.2021 19:03, Andrew Cooper wrote:
>> I'm not a massive fan of the large ifdef area.  The logic could be rearranged
>> to use IS_ENABLED(CONFIG_XEN_SHSTK) by indenting most of the function, but I
>> can't see any way to drop the goto's, and this is certainly the 
>> least-invasive
>> diff.
> So perhaps the build failure I've just run into (also apparently spotted
> by osstest) suggests to actually do so? The alternative would seem to be
> to widen the #ifdef in get_shstk_bottom() to cover the function as a
> whole ...

Let me see how the options look...

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.