[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v6 05/31] build: factorise generation of the linker scripts
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 13 Jul 2021 09:28:35 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SDZRzSsMsHriMl7Ei0wanroOEzhHhSecTryBf7rF50o=; b=VFgNoXolhPb1EATeLpzbcux72khhSHtd87SCmR3mGHEbhhe7K/WvK6KJM7ZdHlrUQ5HrX85RhZk1JDxXSJ9T2GA0X4wN7e5xoxrpcJvSaBxQN6fFnBFKzNbsLGvY2d0e6voz34SeuztmJlqpxTFDa/o/R73A3KjW25BoxW/bdQC/kDMHP0CHJagitQd5u0PdGgUJT4KsJjwNNsOEl16NbB4HHO5pE8MyZe3PJNUacYLTqwcWjI4O+Fe3dAW7QQM03BLt7WplSsJipJsXlRHuR2JFmXX2yK+OV3ZxR0FD4hQTLYb2ioqsyfc/nkm7WmfGr5cEW4F7X0s85AP3R49JmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QRBH4DiZMiLOlI077vPqrdRk4kFc2IcRuXTw2XEepjzUQ7DBhsDFh2obE9VrQc7XjViCln0xrxu3GL4FsqXt4kzhRbZNalp3/hSyEsNc59Kg4f6W3q3uT63IWt4m468lgT/EeJREyGakVNShW8rN/hp90lZTQxoGRaDKOuZO9WVNOkB5Qnq6NZflvt1gwExsFHZSyO3Bp4De07aqk+LlVV6v1eJ+9Y2unfJhE0dn7byV1g8n3ltnrkf4RLO1NX050CCj1QTPy+y1m1IarUH+fF0QcAiTISfdFEKIdtRLnKo2NxOItvkJH252cYce8ankyBNqf7aPJpvahscjuDm8FQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 13 Jul 2021 07:28:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.07.2021 13:02, Anthony PERARD wrote:
> On Wed, Jul 07, 2021 at 04:25:33PM +0200, Jan Beulich wrote:
>> On 01.07.2021 16:09, Anthony PERARD wrote:
>>> In Arm and X86 makefile, generating the linker script is the same, so
>>> we can simply have both call the same macro.
>>>
>>> We need to add *.lds files into extra-y so that Rules.mk can find the
>>> .*.cmd dependency file and load it.
>>>
>>> Change made to the command line:
>>> - Use cpp_flags macro which simply filter -Wa,% options from $(a_flags).
>>> - Added -D__LINKER__ even it is only used by Arm's lds.
>>
>> I'm not really happy about this, not the least because the symbol's name
>> doesn't fit its purpose (we're not linking, but producing a linker script
>> at that stage), but well ...
>
> Also, the leading "__" is probably a bad idea as I think it's reserved?
I guess that's intentional in this case, matching in particular
__ASSEMBLY__.
Jan
|
