[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v6 05/31] build: factorise generation of the linker scripts


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 7 Jul 2021 16:25:33 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r3rh64MjpZjPhmlcc6u0Bx17Oku/17RC5NcEjFP3oNY=; b=BcpzLyH84htpYGhBhj1E96pI+z/Oj1IL4gnWVDP7UiXGfogNq0CPo5kn5/4PjSHlvI9R8Ba6veEubNxCmqEPsVMvK9LCFsamuAIdLzDsbPZFnMf4hUPTw31ngr9WNRgN8ZvXl2c3nuzyBNeLAoDTtBNAPtpeZ4HyTJNHuFpGs8xIamPbUPhIO8/sD2in+et4qy0c5TwYhzrGDbOfoP3t8PEMruXmwboRO5PLAsEdVG5CXjV65OM+gC8YHa7xYpH1FYfgaA2X7+02k8t+0lkyBuUFyx6bnlGs76360tkNWc6FWRKmhR34DTGc900HIPISUhko91Bqb47P8u/y2GHFIw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ogja5LL0LNw6156S5atIajdyDOgmQpF1MX/8ExM1k/YpVpmIAAtjewcm2qErYBKrHiGM0ncEpsijiAViu0J3CheqKSxzks/Xx/FGMUqVRXfpfKRvc5R3oC0Vd6L7wDv1axHaJdgEvHBeLX5lkuK8xQt1ba8/ARKYGwoUQ/ctgvseIAJVi8UZE9MXl8wMsb9+3yT2ctqJKMnb7YkwrTZXxP/tKdlJwRQp1S5zGktiuSbUPCyAgKvRx+Ww/FuxwPE+4Mm0rFubO2M5JVlH4TVwCo9fcBRS21olH3HGSsr6GEcZ1sZkEY1NHCZ8N/306fi+tgv5maLqEZCXGhtxOB5mHA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 07 Jul 2021 14:25:45 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.07.2021 16:09, Anthony PERARD wrote:
> In Arm and X86 makefile, generating the linker script is the same, so
> we can simply have both call the same macro.
> 
> We need to add *.lds files into extra-y so that Rules.mk can find the
> .*.cmd dependency file and load it.
> 
> Change made to the command line:
> - Use cpp_flags macro which simply filter -Wa,% options from $(a_flags).
> - Added -D__LINKER__ even it is only used by Arm's lds.

I'm not really happy about this, not the least because the symbol's name
doesn't fit its purpose (we're not linking, but producing a linker script
at that stage), but well ...

> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.