[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tools/migration: Fix potential overflow in send_checkpoint_dirty_pfn_list()
- To: Jan Beulich <jbeulich@xxxxxxxx>, Olaf Hering <olaf@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 6 Jul 2021 17:08:26 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EhBJSMffj0WekHiNCUjxdEbJ/5FzByTBTqtLD8GvgyA=; b=eTpTjqS1DeLTo9tjSteZmE72cVWliJpredhVasCihbd0XBaKHRTI/82cq/MEt3Px+kEjWaYQnaUFshJ+bDzKOWGdriw2jcWbxvj+U6CFb93uN/1QlvyR5IONQ+kwI9ySl89F+L258ztI+YrIiGJu6PQ6D1JidfNRLNis7VrGXY83+SX63VAIBvbzxOEJFXr3/oyC/2lm87msHvK6PCwcoH4smWANwqMHmgY0aNdsRkZOx8VpFi7ahmjDygfY2jzr5srrXVtJr4Qs9uVE5fJgMnD+k86EPl9nC9wvfYXzMUIsVX4VoySGIl+OXLSqGHw5YLGx/OSqJHf+6PedNj2I/w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SbmNuRoBKImC5+LzX0Zv/pHD1nO5gFYdMk3+vMG9kJq0wF0c8XgwG3FzzYmNknv3PYPl3qD14iLNs0AN/YB+cKiM40q6yA11lPrhxpz92yHjVRj0CtmR8USsCtpsnX1+EJb2c2YEcqHmoYR0jpcxvtuWDL4Wz7y0u2ssUek7JqK57marTuQjZwOJGHQ2dbuoxWIqQ/AelBFpYrkI3Qrm8OCXuceoP4QsAl94iv5CgUOa7gR5GtliofvVrqr7SSML5ZS3Hj2gdIMp5tNhQt5wdQ14VCNIPat9gN1cGIZ98nkUp4FQDsyMI97QMFhfGK6bTXHUqSeIU4VF39p2yJTqxw==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 06 Jul 2021 16:09:02 +0000
- Ironport-hdrordr: A9a23:YQz7c6n4KBPkR7LWFdHjBwt9SarpDfLU3DAbv31ZSRFFG/Fw9/ rCoB3U726WtN9xYgBYpTnkAsO9qBznmqKdjbN+AV7mZniChILKFvAF0WKB+UyDJ8SWzIc0uZ uIMZIObOEYZWIQsS/U2miF+r0bsb66Gc6T5ds3zx1WPH5Xg6ML1XYGNu5MeHcGNTWvBvACZe qhDtIsnUvZRZyOBP7LekXsWYL41qb2fMKPW299O/Y/gjP+8A+V1A==
- Ironport-sdr: y2gtkoZybMovo53fGYeuuNyHKVNvH6vZcGcmMYoFaBdfbNGEioatvr6DQrK4nce1DhmykNUY3D CFIqO607cl2i53GY2o+tJvm/HpBps8310hiYNZJTHiZSeamKVPDeTq9CoNEHKjCvbDwjjJOub/ UATPtXbU2PPj7B2e+gUvoqUZo/Sc3qQ8lFyOgZu5OHWjmNyTIpWpI1jXwr0ek90PReoiAbcCy9 CxJLeufV+U/h7dg0shQGcj6faCOcCPDwL8UkLVsZ/Ap/zjNzxYSrL5aGKa7GnwSAcCIqSmpvDb Gk8=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06/07/2021 16:22, Jan Beulich wrote:
> On 06.07.2021 17:13, Jan Beulich wrote:
>> On 06.07.2021 16:11, Olaf Hering wrote:
>>> Am Tue, 6 Jul 2021 14:58:04 +0200
>>> schrieb Olaf Hering <olaf@xxxxxxxxx>:
>>>
>>>> the reporting is broken since a while
>>> A quick check on a Dell T320 with E5-2430L, which does not have "Page
>>> Modification Logging", indicates that staging-4.5 appears to work, but
>>> reporting in staging-4.6 is broken.
>> Not surprising at all, considering PML support was added in 4.6.
> Or perhaps still surprising, as the functions involved there don't
> appear to be bypassing any core logic, so after some looking around
> I can't say I see anything that's obviously wrong.
>
> Oh, and I notice only now the "not" in your original reply, which
> renders my earlier statement completely pointless anyway. I'm sorry.
Ok, so my observations of dirty_count being reliable during development
of migration v2 appears to be correct, and something regressed in the
dev window where it got committed upstream...
That is suspicious.
~Andrew
|
