[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] tools/migration: Fix potential overflow in send_checkpoint_dirty_pfn_list()


  • To: Olaf Hering <olaf@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 6 Jul 2021 17:22:38 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cy/JGQXsILLmQRO0360/zAHS9br+wbwC5WUI/DjT2WQ=; b=k9/3MoLdeufUqTybcwbKghkgnnhEv4TfFD2V6PSEhsqBQusBGhiO3aeCT1s9vgG592ARG5vclx8A958yuepQNATg34hl1wR5gnH/UoheYe0FQxQdiIvP9UQSO4W+OT8grBEHC4PExeebn/9eIFfnRcrGGwDSFR2fw/gUCDLHGTKNsbCFxnf9ymI2QgwioKBmMqojd0Te3dPQSHjKZFD8KRTu8XPdyjGkyH9p4iin2TJqO0wLszywHu/LslKCopCfIcoy8+LvHUQgr14L1QwDWucGAEKgyy2LojAJqvPQcM3RO2LllP0fr00AkX9rZkE6bNjtgwIMQRzgnrwo/a+l0Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kAXIEw2GtALG3ohDZMaLXh7zToGFf6DuGmcDsX2V/fhPcXsjzAVUwYCRc9U+su4KL6OZ2Q1/tpgwnEYNxRWeQrRvO7FA3H1/eQFJOs7SR3L/1fjNrwrezmXsZZe9tmU6n+tbcxKp+qlayY++3ZEaq0cgU/iF70EtPs1n4KXs1vYymC5H+T4j4pdXIBt6tPcZoTk6JpkiOjco0e0Gsuw4h9tNF71AUi0yaIPDi4HmliFt8xpg9G8OV56YBtH9FwgEDKMT4fZhtE/PIhWkUiy6AA0qag47Ccct/b0NalvuzwAZCOp9Wx4BoBQcZa+bUmmpSh8xsrR9brRjR8KgnFWxBg==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 06 Jul 2021 15:22:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.07.2021 17:13, Jan Beulich wrote:
> On 06.07.2021 16:11, Olaf Hering wrote:
>> Am Tue, 6 Jul 2021 14:58:04 +0200
>> schrieb Olaf Hering <olaf@xxxxxxxxx>:
>>
>>> the reporting is broken since a while
>>
>> A quick check on a Dell T320 with E5-2430L, which does not have "Page 
>> Modification Logging", indicates that staging-4.5 appears to work, but 
>> reporting in staging-4.6 is broken.
> 
> Not surprising at all, considering PML support was added in 4.6.

Or perhaps still surprising, as the functions involved there don't
appear to be bypassing any core logic, so after some looking around
I can't say I see anything that's obviously wrong.

Oh, and I notice only now the "not" in your original reply, which
renders my earlier statement completely pointless anyway. I'm sorry.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.