[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/16] x86/P2M: introduce p2m_{add,remove}_page()
- To: paul@xxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 6 Jul 2021 09:05:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUpr3RDGFTqGWjEogHhWrI6pokeMjD44aLKIwZvnhh4=; b=fX2PT8IZB1ZO/hVHNVLZ7RFAJM5nUKWoqcxHG56YyLKUkO+0SoKRxvoUQdI7sUq58m8oQUKIbsz9Auv2dIcpfm41imFtmazqRqeBVBg+JPPU05ASsUTH2nQz8nUb2fqwoJ95XYKv5PMhDqP9UBQInubfu76j427F1+xIJFYh4jfFrw3xlaAxCb1j1WF92qucLF6Mxr+JBlKM5KK+p+tnGiA/hcuaxEaWbROcaKJMjqKpfV/aNhx2aAIEWO0s0cvxMQuucvIHhvyWQLK1KfeF8l2GXrLhnHF1KRVGeZYf1jrOZItnkhRHXI5STccwP2ATVpNl4QgCnEg+uGp5jQtYqw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GcEqCrfizHeVNcmJbFCOTfoaEEN0LShy8hAHvAIQI2zZwwgUlQwtgwbCuqntVl9mHxxaBhwyv/lUjzDQmmqdsNNIFUL/dHoIjCjrWXRF1dMyF7/mX89BUl9e6Mv1YILVdwSOaYMMLcxhW+exQlf5Sah420BEtDevTjr55m6rUrJrf+VatVEoFZroUrzLUzRiTw2EiiEE5tJcVd209abql8ftEx0IB8CEYdrbMXfgGeVFnjyjma3LMxe+LK/4Xk2pQy11dU9rolo3K1WQqc24nSTzSYFPucZVVubOYmUSirdLPLsSFyGhwfvyrL7QhnCQP1EYaADKAr/Asm5kn/jJKQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Jul 2021 07:06:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.07.2021 19:47, Paul Durrant wrote:
> On 05/07/2021 17:06, Jan Beulich wrote:
>> p2m_add_page() is simply a rename from guest_physmap_add_entry().
>> p2m_remove_page() then is its counterpart, despite rendering
>> guest_physmap_remove_page().
>
> Did some words get dropped in that second sentence? I can't really
> understand what it is saying.
Oops - this was meant to be "... a trivial wrapper".
>> This way callers can use suitable pairs of
>> functions (previously violated by hvm/grant_table.c).
>>
>> In HVM-specific code further avoid going through the guest_physmap_*()
>> layer, and instead use the two new/renamed functions directly.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>
> The code looks fine so...
>
> Reviewed-by: Paul Durrant <paul@xxxxxxx>
Thanks.
Jan
|
