Re: [PATCH 02/16] x86/P2M: introduce p2m_{add,remove}_page()

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 05/07/2021 17:06, Jan Beulich wrote:
> p2m_add_page() is simply a rename from guest_physmap_add_entry().
> p2m_remove_page() then is its counterpart, despite rendering
> guest_physmap_remove_page().
Did some words get dropped in that second sentence? I can't really 
understand what it is saying.
> This way callers can use suitable pairs of
> functions (previously violated by hvm/grant_table.c).
>
> In HVM-specific code further avoid going through the guest_physmap_*()
> layer, and instead use the two new/renamed functions directly.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
The code looks fine so...

Reviewed-by: Paul Durrant <paul@xxxxxxx>