[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v20210701 11/40] tools: use sr_is_known_page_type


  • To: Olaf Hering <olaf@xxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 5 Jul 2021 10:53:25 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rGHLu1ry1POJGU3WUjTWuDM+pYHXRzmMY7QF6rI9q9A=; b=KR9U8greMHT0d9PDh0T444bsAhJK6FeuItDCnrW5zW2Y2d7673Hsoh6IZv9wSTDYIM5lD1htBY2R0FuBBG4f25g6z9iHB24Sk71s/Poj2sPBLSllVgLypqS66dZTI79UzKGQEYrJvV3a+H2qtAXjYV8uhG0mlFQpS2p5BYSMdJ0wAas6uPtrITwNQ/408bhOAEex4fFtW0fEpNB1Y/XoLE72/BRsIyhqjfc9RbhZ++q01F+Eww9OvoUt2Lo9ovV+EhFqU2PlV1n84tuWWUX4jNmoze2nLtEZvXaIb4TKjyKN/DOECD1t0fcHeg1uzjyW4wEAPDBDHeBrNYSm/klAuQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F397DwiyIw4lI82I8wJmw93aaSl2ky6jBug4BmUmtukaAw12OUk1pake2oVkUJjlekELrxX6uPmWYT61CTM7seNiuPtGzrT7S5AnoubH00Yo5b1zbuNf0s6y1EiGAoMBxj22Ib/2ciAL/xY9GFrxwW8bQzuMwnuofc6b/qGNP3HnED7kk+Djg6WvnUPHVNhpjium6d6M10mM82N88Nb0R/Vbi0Wx/Whl3o3jN+B+UFx4IijQudhYneN4bQFY5KY24/JduP0GaCW7rRxPdsv7BRfbxpHnYCjQdX4nP0hNIrPkcJKz1V+ovTWGg4iM6n9/UBMPXgo0wl5sdgx+/1/Pgw==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 05 Jul 2021 09:53:40 +0000
  • Ironport-hdrordr: A9a23:q+s7fq0PxUgJKOe7u+axdwqjBVlyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5OEtApTiBUJPwJU80hqQFnrX5Wo3SIDUO2VHYUb2KiLGN/9SOIVyHygcw79 YHT0E6MqyLMbEYt7eI3ODbKadY/DDvysnB7o2/vhQdOD2CKZsQiDuRYjzrYnGeLzM2Z6bReq Dsg/av6wDQAkj+Oa+Adwg4tqX41pH2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U XMjgS8v8yYwr+G4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls XKvn4bTotOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpMSfx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvEbf2UIUh6LD3wXklVKvpREnBmcca+a hVfYDhDc9tABGnhyuzhBgo/DTENU5DbCtvQSA5y4eoOnZt7SlEJnAjtbsid0E7hdoAoql/lp D525tT5cdzp+8tHOhA7bQ6MIaK4lKke2OEDIvEGyWYKEhAAQOUl6LK
  • Ironport-sdr: RJJIH12niI1/DUbz45NHXMRahcvlpmHfpF4EicFekbEGSjKqG7xMPd8fcRJRFLB+tHYE767Utq R0Hpb4nQ7MX+9qs8KhBT/+xuyabzVwjmy/xZ9YDsFvSYcwHZSfPzvNW1vhpCZvzvCO6EcIPyXk aZa7cA18HUIpHuKmsgm6f+B/PO+y4xjXXP/pf/QYEylhCxOTe2kN26JUltGX2ezd25+zI6NXRa V7S/hKDmnahEmEMEOAPd55pEKgt0mYCkj1yIMGNvvJ9RBC/S0swq3Zh2WmjcDnUO6d2ndgtbDr IB0=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 05/07/2021 09:25, Olaf Hering wrote:
> Am Fri, 2 Jul 2021 20:27:21 +0100
> schrieb Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:
>
>> Any reason this isn't folded into the previous patch, like your
>> subsequent two page type helper patches are?
> I think I wanted to separate this for simpler review, but I forgot to split 
> the followup change as well.

All patches are largely mechanical changes.  It's easier to review
together, rather than split, because you can only judge the correctness
of the new helper in terms of the code it is replacing.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.