[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v20210701 10/40] tools: add xc_is_known_page_type to libxenctrl
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 5 Jul 2021 10:51:50 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w6chlBY/ISf0K7dfNK7yktQk8072F0L0VK+2+ixf0Ac=; b=FnfVBi6FNR6AM8523j4vID67eUFL6OXDXG5tIUycWDXV6SNRwxBPpJCULYhHK/CcIVuxTx73dHrpHJUOm6kd5yuEiYDcFNJJjxYWmkbgmxw65rIZPjpLmacLAHwEjKIEnaTn2zCXM3MpMVZIVUNL/WzotTGFBeIQ/rIUzUGkq1QfZ9DdYO965Alb1dh8T+1ndvJzGYlAkL1C5ecp9G0XSrnlu9oirRX77KwhHW895+etp18Vsk/9bBKq4iu04+JPfav2J6W7T+GwwWdLJDEcni2rpEVI21gyGRjAgXpa90rPKf9WSPam6cfAzBuG7SDE4CBa1WS3uhnuzv4IqyS5vg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SXWPcv3skpAFv0IvhqPmaf1sYlhPKmTrFji5OpnLfige1pZkQZoYarHU1deVVKR48rXUK3hfUZQWNyWjftSY0yABGR5Ea/j/fm/VfKTRlK/u6KED2FMr+YDjZNZOcfyh+lAeAybqqm4O8NwZDcEA5Q9e5JFMp9u3XIngCxgizlSSKbpbsQ3mafucZikdPRpe6/fGbdB47dUZ6hyP6yDAeSc++rj7robY8GriuwUGyvakiLCdX26en7BPu1TjDEUjNzecGX5RJy4RPG/SX4vOef6dgtlvSKJtBGvkXUhdHngDXzfmmxPHnAy1u80lmqRHLS/wcJVVTrGLe5Pgga+fbQ==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Mon, 05 Jul 2021 09:52:31 +0000
- Ironport-hdrordr: A9a23:Xj0ma6j7s2ZirqfdkIQYAGqU33BQX2d13DAbv31ZSRFFG/FwyP rOoB1L73HJYWgqN03IwerwR5VpQRvnhPlICPoqTMmftWjdySuVxeRZjbcKrAeQYBEWmtQtsJ uINpIOdOEYbmIKzvoSgjPIaerIqePvmMvD6IuurAYOcegpUdAc0+4TMHf8LqQCfng/OXNPLu vk2iMonUvFRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1UjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3DRY0eTFcBcso+5zXYISdKUmQ8XeR 730k8d1vFImjTsl6eO0EDQMkfboWwTAjTZuC6laDPY0LzErXQBepd8bUYzSGqH16Lm1+sMjJ 6jlljpxaa+R3n77VfAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdg99Q/Bmc0a+d NVfY3hDTdtABunRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOth5zv WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdI1JVsJ6d 78uXZjxCcPkm7VeLqzNaxwg1vwqT+GLEDQI+lllu5EU5PHNc/WDRE=
- Ironport-sdr: 4ZNjjD5IQ9ScxIZyWxaqYdJLHVl1GvBroQfhRI93h+dzUsVg7fapXLoaIgSXAjWMiHzo6S3xIv 43VWkX6/bpBZkKyGkZXeS8V45CpQuZN0nGOeF+JE/nw7YveZAR6YtVQkFYRY9Xuk+XTtIO6M+/ 1aetUu9fFWFlIJrdFMiG4uYyoXNwx3lUIg5P98yY0ErzU+yH8UU+bZhX1k1k98/tVz9M/Rd9Nx 2ZgzmW3gJQT8P460I6vGK2D9mCC11BqrqNBZc5L6RcJxKTTPAQSeoozxqB6nx6w43RGoqauZkG yRE=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/07/2021 09:22, Olaf Hering wrote:
> Am Fri, 2 Jul 2021 20:20:08 +0100
> schrieb Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:
>>> +/* Sanitiy check for types returned by Xen */
>>> +static inline bool sr_is_known_page_type(xen_pfn_t type)
>> uint32_t
> Why is this better than returning 'bool'?
For the parameter sorry, not the return type.
All type fields are uniformly uint32_t elsewhere.
>
>> I can fix up everything on commit if you're happy with the suggestions.
> Yes, I'm certainly fine with it.
Ok - I'll put together a branch.
~Andrew
|
