[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libxencall: Bump SONAME following new functionality

  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 25 Jun 2021 12:36:58 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=in9Lg7Ky5DALGXZNGc9gusfBYFGjuGqkZQqLp4Nv2kA=; b=FD39GX4Mz9fPWuBT4kAHlRyz4A7BG535Ish2DkZyFnhFXofFtKvZJyuuklUcpM4YU+fK/fMjty8EQQfyN20ggayVN66degh+bshnpcwror2plCVJ9Z8qk7Yn7hOAkKqm32smyMm30EIV/SkFoBNTA4tDtsldkEziqRTK27EGM7enqd8xAmzsFZqDnBJGyYYpJK/g1exYl9T378dfn4IIZNfCeIaK0lCOUaXocjE6e5tQFB6Ko8HDxY/hgW3GCpWEWK8JnlS1Tc+XZfq27FB5q/NmKBAODA1w2M9tAorbKS2M2rzWpTiAfMDYHkmryDYZeIJCTdq5oYhRoxeT+/kseA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Za/kN/S8F17zJnRXLijtDqYtxKbTPjBVVDBMhBg7laFg+e9erh9Y0+DbxfTOhtzajkG7nVuKxm8RJuZ0+Y1yPjP6rgP4JDjZKN+rGdW/s7NAedXwozxqoam8usPGqk3AurY1gfN3qsYa04E0E8/Z35iCcmP0LtQYdpJ3x6ByhYEnZVjaHlPv0Cw9EYqKNROlTYVCLPQ5AW8uwimU+YBYQ4Eq12DuZmF0m5fcJiI3MCWFTz4iYhVO98nO0SeLyKhPeNKe4Va4ux7QaElaP/bO+mbI/1MgZdwABXOKY1JiBcmX1YCeSPdNiQcP9YNAI51ZICHRC2nNYNfBr//GEgMd4Q==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 25 Jun 2021 11:37:19 +0000
  • Ironport-hdrordr: A9a23:UZIWsahbaMv1fAd8crKZvmwp8HBQXiAji2hC6mlwRA09TyX5ra 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II=
  • Ironport-sdr: Mpq/vtWK8kR1Bk+aeBGvTsAaXL7/Kzr/bmMOPMts2IBDztEfiiHZiZkSHlnQ/y0OdMOYfdrcTn NSVR/TTzTHL4mg48I1w0dC+XXSWm1QcJN2Fv7Mr6mSGoOZWUdkV5psTKKKPj5Eo8vVlIZQN6sG 6CblbycOq+NYHuBg7ctao9DVV8a+LJL3OtYpVxfTehilWTzJTU3V7izLxTApgTFPjLaUWd9KdC /h105F806R8X46gdhhe4a8qb5hauVpJNkEyQUc4cIFRzKD0W2E4do8MHyq17ZifNBR5tIZYebf Vs8=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25/06/2021 11:59, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH] libxencall: Bump SONAME following new 
> functionality"):
>> On 25.06.2021 11:17, Andrew Cooper wrote:
>>> On 25/06/2021 07:31, Jan Beulich wrote:
>>>> On 24.06.2021 19:55, Andrew Cooper wrote:
>>>>> Fixes: bef64f2c00 ("libxencall: introduce variant of xencall2() returning 
>>>>> long")
>>>> Is this strictly necessary, i.e. is a Fixes: tag here warranted?
>>> Yes - very much so.
>>> andrewcoop@andrewcoop:/local/xen.git/xen$ readelf -Wa
>>> ../tools/libs/call/libxencall.so.1.2 | grep 1\\.3
>>>     33: 0000000000001496    59 FUNC    GLOBAL DEFAULT   13
>>> xencall2L@@VERS_1.3
>>>     39: 0000000000000000     0 OBJECT  GLOBAL DEFAULT  ABS VERS_1.3
>>>     76: 0000000000000000     0 OBJECT  GLOBAL DEFAULT  ABS VERS_1.3
>>>   020:   4 (VERS_1.2)      5 (VERS_1.3)      2 (VERS_1.0)      3
>>> (VERS_1.1)  
>>>   024:   3 (VERS_1.1)      2 (VERS_1.0)      4 (VERS_1.2)      5
>>> (VERS_1.3)  
>>>   0x0080: Rev: 1  Flags: none  Index: 5  Cnt: 2  Name: VERS_1.3
>>> Without this, you create a library called .so.1.2 with 1.3's ABI in.
>> I'm aware of the change to file contents as well as the disagreement
>> of file name / SONAME vs enumerated versions. So telling me this is
>> not really an answer to my question. It may be by convention that
>> the two should match up, but I don't see any functional issue (yet)
>> if they don't. Plus of course you leave open altogether the
>> backporting aspect of my question.
> The patch, including the Fixes tag,
> Reviewed-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>


> Changing minor version in the filename as well as the .so is not an
> impediment to backporting.  The actual soname remains the same so
> there is no compatibility problem and the change is still suitable for
> including in eg distro stsable releases.

Correct, although backporting in general however is problematic.

Until Xen 4.16 is released (or, we explicitly decide to make an explicit
library release early), the 1.3 ABI isn't set in stone.

Backports to older stable-* branches must sit on a boundary already set
in stone in staging, or we'll end up with different versions of Xen
having different ideas of what VERS_1.3 mean.

It also creates upgrade compatibility problems created for any distro
who's installs of newer versions doesn't have internet access to pull
updated packages.  This is a consequence of having different versions of
stable libs bundled in different releases of Xen, rather than having
them entirely separate and packaged by their soname alone.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.