[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxencall: Bump SONAME following new functionality
- To: Jan Beulich <jbeulich@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 25 Jun 2021 10:17:20 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mJ8eqNyNs7/dCmR6PTTBtcxOGRd9HDC6bMxJaQ+V+NY=; b=KOqGk/x+SBRd0xsIzUbwvK6bGuWJGPhykns26sswXTlyOeABl6OFNU1TLXVJICWBXYz3LfWyWX0NmxeVSjeR+u0rPmZUZE7VbSJB3X6ac8lDuTuJsGtvbyoXtWGdDOuJB3qb56cz+RxlZbHfiDPCTuam4hxP32dnRA55VCZUE1MTN2oWxRjGD7DAdwuR9o5hrTdJh87DL9Dq9z2Bo0a/engLlRB9Xhz9JU8zCLdXU2PO+3CUyhrbsvVc4rqjuBJq3SouGIorncttRY6pTnIylfhUMr56uXSIP//2rWDXX6XvseK1oXLPnoRiFsPZEHeEJM6F+EbjH1ufiQff1TSHTQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H5ir3iIPv9nJONYzxw2ApDJlyLYx3bu9H83xnMru1cF3sIwi/W/h9ONjdkpr+G+/3xNN+8SRY7BFaeToPqC1HX5+rI4lXDEeBd42fvDwuJQR1hK/sbM4p8ZpJnaHmdpIQrKRRHXMx5akassg37u4li6jNykRii50Fw+Ic7kOrL6D0C0LjDq2i0HYIxAxzZh4nMlblW4piT6kNrQPjb0hi3S89V9LAJS3QVZQ639tIVBg7Hauh1oikTiXJiWkSMP7FHKZodEjRpusFtcAN1Q+34Y54/KGDZhDgucfIkYIAy4wVy0ja4ynfcjYY3YMxQLquG+W6Ig+oUZb5YkfXEa9vA==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 25 Jun 2021 09:17:40 +0000
- Ironport-hdrordr: A9a23:aH9nWqGBiMbYMGSIpLqFA5HXdLJyesId70hD6qkvc3Nom52j+/ xGws536faVslcssHFJo6HkBEDyewKiyXcT2/hsAV7CZniahILMFu9fBOTZskXd8kHFh4lgPO JbAtJD4b7LfCtHZKTBkXCF+r8bqbHtmsDY5paq854ud3APV0gJ1XYINu/xKDwReOApP+taKH PR3Ls9m9L2Ek5nH/hTS0N1E9TrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJqJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87CsIDoBW0Tf8b2u1qRzi103LyzA18ULvzleenD/KvdH5bChSMbsDuatpNj/ir2YwttB116 xGm0iDsYBMMB/GlCPho/DVShBRkFauq3ZKq59Ss5Vma/paVFZtl/1awKsMe61wWx4SqbpXUd WGNfuspsq/KjihHjbkVgAF+q3fYpwxdi32CXTq9PbligS+p0oJuHfw8vZv1kvoxKhNP6Ws2N 60RJiAtIs+BPP+PpgNSdvof6OMeyXwqEX3QRyvyBLcZfk6B04=
- Ironport-sdr: HcR1qPUHpQdg3GnC92ivq3D95T5jgt/+zUAs2U31INP96c1m0DW7tHiPWiCP9J+kVcVRS4DFdH aC140Xrfvjf9JjLpXOlR6qMiu6Z/ZkZa1ecG3WBK2HPhIg288J/TuoWhdp7vM/xU0R+mckSESe H5jC1c3gv+S4nKhyATwO6os3eeU3g6siz3SQdr0jrcKhoC9CCfHoMxv/PA9gINuRlLv+LhX454 rqpupb8BAF7XdcCEF6s53M0ss7lVE8A1MV0C4tYdBvYZjLU+Me0QmnI2d8NkbsOtP//C3BAbHH 5a4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25/06/2021 07:31, Jan Beulich wrote:
> On 24.06.2021 19:55, Andrew Cooper wrote:
>> Fixes: bef64f2c00 ("libxencall: introduce variant of xencall2() returning
>> long")
> Is this strictly necessary, i.e. is a Fixes: tag here warranted?
Yes - very much so.
andrewcoop@andrewcoop:/local/xen.git/xen$ readelf -Wa
../tools/libs/call/libxencall.so.1.2 | grep 1\\.3
33: 0000000000001496 59 FUNC GLOBAL DEFAULT 13
xencall2L@@VERS_1.3
39: 0000000000000000 0 OBJECT GLOBAL DEFAULT ABS VERS_1.3
76: 0000000000000000 0 OBJECT GLOBAL DEFAULT ABS VERS_1.3
020: 4 (VERS_1.2) 5 (VERS_1.3) 2 (VERS_1.0) 3
(VERS_1.1)
024: 3 (VERS_1.1) 2 (VERS_1.0) 4 (VERS_1.2) 5
(VERS_1.3)
0x0080: Rev: 1 Flags: none Index: 5 Cnt: 2 Name: VERS_1.3
Without this, you create a library called .so.1.2 with 1.3's ABI in.
~Andrew
|
