Re: [PATCH 07/10] tools/xenstored: delay_request: don't assume conn->in == in

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 24/06/2021 09:44, Juergen Gross wrote:
> On 16.06.21 16:43, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > delay_request() is currently assuming that the request delayed is
> > always conn->in. This is currently correct, but it is a call for
> > a latent bug as the function allows the caller to specify any request.
> >
> > To prevent any future surprise, check if the request delayed is the
> > current one.
> >
> > Fixes: c5ca1404b4 ("tools/xenstore: add support for delaying execution 
> > of a xenstore request")
> Is the Fixes: tag really wanted in this patch? Currently there is
> nothing wrong without this patch. So a backport will be needed only if
> e.g. this series will be backported. >
> I'm fine either way, but I think this should be Ian's call.
We don't usually backport to stable for tech preview (Xenstored 
Live-Update is one).
In this case, I mainly added it because it makes easier for a developper 
to figure out where the bugs comes from and downstream may want to 
ingest it. This doesn't mean I request an official backport.
I could just mention in the commit message if you prefer.

Cheers,

--
Julien Grall