Re: [PATCH 07/10] tools/xenstored: delay_request: don't assume conn->in == in

[Juergen Gross <jgross@xxxxxxxx>]

On 16.06.21 16:43, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> delay_request() is currently assuming that the request delayed is
> always conn->in. This is currently correct, but it is a call for
> a latent bug as the function allows the caller to specify any request.
>
> To prevent any future surprise, check if the request delayed is the
> current one.
>
> Fixes: c5ca1404b4 ("tools/xenstore: add support for delaying execution of a xenstore 
> request")
Is the Fixes: tag really wanted in this patch? Currently there is
nothing wrong without this patch. So a backport will be needed only if
e.g. this series will be backported.

I'm fine either way, but I think this should be Ian's call.

> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature