[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] tools/tests: Drop run runes

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 16 Jun 2021 15:59:13 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wJuPjcrNXkrHMc34KKYfciYUx2XknK5hLSr7ZRq4h4Y=; b=GZV69zm4jwMIA3bJ/B/BDrK1+M0OYqao4R6gJnKWCaYMKsCRwuzlmDV37jmVh+/MhXlzlfxJouclbqNNWq5NWfrmIdGEp623wp0yPwIqymrIgGJzoXtjOCN+jrbTnG7gVvlA2o+/bgwyJUUkk3u88JOcbgN5t1/uKZ4J1R8606ZY/lbiRVc71KdRh7Q9Og/Gq659n+XJXAKdiEQT0dPK467zM2h58GRGu+Xxn7uD6vsdqvSnp2Yzl/nSgMl9gyJuPgIMbhihB3gWVDgVrjcJ+XDAziF+dhdUw/iStXVS/bYM1lQatAZ7Xv6PUPGdWKBfBobdqz1dUYXVlQIbh7ELhw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B2aMciyO58vpLw/AhOczfLoXNDHRDqe8y6+S2jeB/1QNLq5azpipVAA9ARcFsh2hsMlxDLnV0XtcIiphrjTx0kVkW7StnZhITpJUgdSuiXweVpBT3d2NJieJqITael4dOEuqir/Lu584zjvvhRlHChd1yZrbx/nmKup5mKQnw6MZAMEyRJRjhHiTqnlBjDIt33XLGiE6dJG39gMdrfHZXLQPZlhFLxbnEU7Wp8WaHMhxb0RSlP9Pqt/l3CxXiIxwEC1cGZk6YFfpcsoFAmFeciCrNV10JNZmXiu2OkjolE1W2SLh7WU8pYwjsDSz7O12ZTMl1SgOozyz9wx+vf3CPA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 16 Jun 2021 13:59:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.06.2021 15:08, Andrew Cooper wrote:
> On 16/06/2021 07:44, Jan Beulich wrote:
>> On 15.06.2021 18:19, Andrew Cooper wrote:
>>> --- a/tools/tests/x86_emulator/Makefile
>>> +++ b/tools/tests/x86_emulator/Makefile
>>> @@ -7,10 +7,6 @@ TARGET := test_x86_emulator
>>>  .PHONY: all
>>>  all:
>>> -.PHONY: run
>>> -run: $(TARGET)
>>> -   ./$(TARGET)
>>> -
>>>  # Add libx86 to the build
>>>  vpath %.c $(XEN_ROOT)/xen/lib/x86
>> This is not only incomplete, but actively (specifically here for my
>> own frequent using of it, but other tests I do run occasionally as
>> well, and then also that same way) harming things as long as you
>> don't introduce an alternative way. Note the top-level Makefile
>> making use of these rules, and note also the run32 companion here.
> Honestly, this makefile is borderline impossible to follow.  I failed to
> make the install runes work, which is part of why I deferred the
> unit-like tests for now.

Well, yes, it's not pretty, but I lack ideas for a clear improvement.

> But I'm taking this as a strong preference to keep the run target?

Yes, and not just here. Any test that can be run directly in the build
tree would imo better have such a target, so re-building and running
it can be invoked with a single make invocation. Having to re-build
the entire tools/ in order to then (re-)run one of these tests is, in
particular, way too much latency.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.