[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] tools/tests: Drop run runes
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 16 Jun 2021 14:08:05 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5O9mg7xjMiZSLFM8fAN66veyxGTyxu0Qce0UXo8k07I=; b=R87pcTK7GOjdXbWF1Mm4tSriinywPoxleanpry7NnvD33CNxj18qWfcEnxNpUpu11J1ro/t/c5BKQ46LT0TqzzWoZXC9eSTuZFy40ZkhfS9hB/hBt0iAXc7RwMOI4eDgSqXstr/LhtbBKZEeGaGw/M4VhkvfEhMDdlNPBNP+nH6piICRp8naw+flbiYRDN59GyQa9jVP/PRpP9kE6Yo1XYvMTrAMsTo977I4ysWEltIbT8x2ebVv6kGiG4opc/kBnKASJIAItqrqnxptAR81NjxSfJLdMS6wTmieTNKwougrtluE2aWuVe/40LeEAeLWHeetpXD7ocvUTx52ORKeEA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FBbjebTFX3Oun0Ft9HWc0byHl2kpkuMtOcknlQAl8hsmsPWpIxdFSM6pPeVGIdILyOZOxN8v009/NWZxAx4+xAA/Ht8TL/TBCyiHUUoH4Olu5BtgvIJQByZTYxkUm8tec3WnjOEZQWjB5mH5VEEeaKos+EdsHRnt4WtQlR+ZIBKA42oGclcvAXdhKLD3hup+6v0teyO+3aNDeEz6sc0U8jO5SuLsYRkJmI7vj87In1WlWiqu2cFE1Rv0YW2Hu8+r1/elFXER/UOsdj3Mzj4iRWUcEQM/sJn1QYV+ijf6sL/vVBdThQYpgt0LvuNMPbVqvPhEqMBQSSh5mjLk58HH9A==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 16 Jun 2021 13:08:18 +0000
- Ironport-hdrordr: A9a23:w/OMMqmH+a4Gwf8DyLxhQ6xdHBLpDfO1imdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdG9qADnhOVICOgqTP2ftWzd1FdAQ7sSibcKrweAJ8S6zJ8l6U 4CSdkyNDSTNykcsS+S2mDRfLgdKZu8gcaVbIzlvhRQpHRRGsRdBnBCe2Sm+yNNJDVuNN4cLt 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9p1CC+yReTrJLqGRmR2RkTFxlVx605zG TDmwvloo2+rvCAzAPG3WO71eUZpDKh8KoDOCW/sLlXFtzesHfrWG2nYczGgNkBmpDu1L/tqq iJn/5vBbU115qbRBDOnfKk4Xic7N9p0Q6v9bbQuwqeneXpAD09EMZPnoRfb1/Q7Fchpsh11O ZR03uerIc/N2K3oM3R3am9a/hRrDvCnZPiq59hs1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgm/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9M1OA7Ae7rDNoXpe2OGDIu/GyWXKEg3AQO+l3es2sRK2AiDQu158HIdou W/bG9l
- Ironport-sdr: ua+CtNaeO+rvzfL/hhXb0jPXAeMPHNCKS6ywtqsyYUPueSJnRazBmBhxZcROrvz5Uzk9rVIXCq vReCZOmLenpNbfm8MmelxKHvlaU5J51bVDbFHv2jfgHiyFo6hXicRilA5Gygm0iJQhec28uE40 dHWpkeQd3ZqXDPAUzmV+pxj8e9A8hBM1Ol+eX2wnU+dsITq5Z+SBC0zVTwKRlXXArUoTJaW+ym nwfA8EW3+rMx05QXJa1rSOBNgAc9N2bxINWAA4aOC1fi/SFVRABkPMGZkewCUFTaaxIldAjczs eME=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/06/2021 07:44, Jan Beulich wrote:
> On 15.06.2021 18:19, Andrew Cooper wrote:
>> --- a/tools/tests/x86_emulator/Makefile
>> +++ b/tools/tests/x86_emulator/Makefile
>> @@ -7,10 +7,6 @@ TARGET := test_x86_emulator
>> .PHONY: all
>> all:
>>
>> -.PHONY: run
>> -run: $(TARGET)
>> - ./$(TARGET)
>> -
>> # Add libx86 to the build
>> vpath %.c $(XEN_ROOT)/xen/lib/x86
>>
> This is not only incomplete, but actively (specifically here for my
> own frequent using of it, but other tests I do run occasionally as
> well, and then also that same way) harming things as long as you
> don't introduce an alternative way. Note the top-level Makefile
> making use of these rules, and note also the run32 companion here.
Honestly, this makefile is borderline impossible to follow. I failed to
make the install runes work, which is part of why I deferred the
unit-like tests for now.
But I'm taking this as a strong preference to keep the run target?
TBH, this patch is a little on the side of the rest of the series. I
stand by my commit message though - these are inconsistent, and buggy in
at least one case.
~Andrew
|
