Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 6/2/21 3:37 PM, Anchal Agarwal wrote:
> On Tue, Jun 01, 2021 at 10:18:36AM -0400, Boris Ostrovsky wrote:
>>
> The resume won't fail because in the image the xen_vcpu and xen_vcpu_info are
> same. These are the same values that got in there during saving of the
> hibernation image. So whatever xen_vcpu got as a value during boot time 
> registration on resume is
> essentially lost once the jump into the saved kernel image happens. 
> Interesting
> part is if KASLR is not enabled boot time vcpup mfn is same as in the image.


Do you start the your guest right after you've hibernated it? What happens if 
you create (and keep running) a few other guests in-between? mfn would likely 
be different then I'd think.


> Once you enable KASLR this value changes sometimes and whenever that happens
> resume gets stuck. Does that make sense?
>
> No it does not resume successfully if hypercall fails because I was trying to
> explicitly reset vcpu and invoke hypercall.
> I am just wondering why does restore logic fails to work here or probably I am
> missing a critical piece here.


If you are not using KASLR then xen_vcpu_info is at the same address every time 
you boot. So whatever you registered before hibernating stays the same when you 
boot second time and register again, and so successful comparison in 
xen_vcpu_setup() works. (Mostly by chance.)


But if KASLR is on then this comparison not failing should cause xen_vcpu 
pointer in the loaded image to become bogus because xen_vcpu is now registered 
for a different xen_vcpu_info address during boot.


>>> Another line of thought is something what kexec does to come around this 
>>> problem
>>> is to abuse soft_reset and issue it during syscore_resume or may be before 
>>> the image get loaded.
>>> I haven't experimented with that yet as I am assuming there has to be a way 
>>> to re-register vcpus during resume.
>>
>> Right, that sounds like it should work.
>>
> You mean soft reset or re-register vcpu?


Doing something along the lines of a soft reset. It should allow you to 
re-register. Not sure how you can use it without Xen changes though. 



-boris