[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode
- To: Anchal Agarwal <anchalag@xxxxxxxxxx>
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Tue, 1 Jun 2021 10:18:36 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iq2IoC+rAI5TZaWS2GJdPAbjYc8YtZgDLuwhYcoU5ZM=; b=Y7kKGoixJj/8zgXMgpG61S6VKDz3mOGzbl9kD1R51cAKuoAltdJoPbyu3zs4JcgkuxCEs3/lx3kciMqUyvairKFvQCAOqDDqpvsXZF4SpLoara0ejZhNEREH18t9EUrMycPojNVnWqs127j96g2pLsIxSmpQUXrGHgpdJh84UyWd7mOWct+ZyUOl5qTP3M6BMuF3OKz5iV/kDWJYFPIOLg0v6vZaSSVmwCnasm/b7Hh0n/5/d9YDfSexTQwcJ1r70w8lEwdwqvqSuvs6DRcXMqx7LiyCT6DW1UKSJXqMAnXdLPJzqVMYOEKo9HOgWD1/8S/zFqGsfV3i++oYtRs9Qg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hrWlft7/ZmgTDCj2a04vWtm6K1efUr0NQGy2C7yHLOx90mxzziI4C/J3hQmndGs2nnCoai84igTY02DM50P3+d8/badr/Yuj0xSq+iJovSR1ysI/ll+mjUWAJzhn6KgqnA3Vd9rRJT0/cAsV9affSHYGOXW+Ut6gXJc9lwnWA00mBIna9Z8JbLTCPSwyf9C3+MCsTEAuP+4OWbKvXWng2COH7CaCb/I98pyG4VT69/3UyqMOYxzJ0viW/3fZiet+aTvU1ZMXgvuRW5t6uE2eNNePaicBRXIJEx2r2Eh8x4t6nFqdEKCf4DK38XyVeHFfqV8d7sYrT16BJNcIYbuqrw==
- Authentication-results: amazon.co.uk; dkim=none (message not signed) header.d=none;amazon.co.uk; dmarc=none action=none header.from=oracle.com;
- Cc: "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "linux-pm@xxxxxxxxxxxxxxx" <linux-pm@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "axboe@xxxxxxxxx" <axboe@xxxxxxxxx>, "davem@xxxxxxxxxxxxx" <davem@xxxxxxxxxxxxx>, "rjw@xxxxxxxxxxxxx" <rjw@xxxxxxxxxxxxx>, "len.brown@xxxxxxxxx" <len.brown@xxxxxxxxx>, "pavel@xxxxxx" <pavel@xxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "vkuznets@xxxxxxxxxx" <vkuznets@xxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, dwmw@xxxxxxxxxxxx
- Delivery-date: Tue, 01 Jun 2021 14:19:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/28/21 5:50 PM, Anchal Agarwal wrote:
> That only fails during boot but not after the control jumps into the image.
> The
> non boot cpus are brought offline(freeze_secondary_cpus) and then online via
> cpu hotplug path. In that case xen_vcpu_setup doesn't invokes the hypercall
> again.
OK, that makes sense --- by that time VCPUs have already been registered. What
I don't understand though is why resume doesn't fail every time --- xen_vcpu
and xen_vcpu_info should be different practically always, shouldn't they? Do
you observe successful resumes when the hypercall fails?
>
> Another line of thought is something what kexec does to come around this
> problem
> is to abuse soft_reset and issue it during syscore_resume or may be before
> the image get loaded.
> I haven't experimented with that yet as I am assuming there has to be a way
> to re-register vcpus during resume.
Right, that sounds like it should work.
-boris
|
