[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Date: Wed, 31 Mar 2021 14:00:20 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XN3Z61BUcb4LwkfP+1OsHmAO3If0ZOxnUhhz51L1x08=; b=EXQ3ig6W5av8gWh4hs8hh7Mex1x5pCPwi+O5DOSlodMNS+iHs9HQc9vXpUxSz/o6cwNPRWv6QUBWEsrfVUILwdFvae/I90rbQOx4mE6MO6qKICHTJaNV+Ex2YhrlGkk9apv3Bf41cfMRZ/lpQY4LZohzAH8g9PiT4RcLkUexLWDA4lquE8rULWh+tSvt9Mp5Eqb0DwcVHuj1BmugHLLDsfwmkD7vr1LGQU9gx8vtMay4vEF9t5XYcC5IlNsgamZowLPbiaRHDZ286ch3yORqlo5xE6u63AqFmKX+l9O0Eb1Mua+K/mQloYFtiNMtBGgjfLCJr+dWuvGXZJpxMjdR3A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HcFr6Ha4VPJHqywRrmkxQ51sZLdPYKDUlMhj9isOR4TRQTPcPMEGN6zINNXTFOBoGMQ+k0h69KfOXKBPeOaInS2R9WYHkfv83a92JsIgASnLlvCNv0ta2VqNBS/MqJ2Hyd42oehZQ7kxL+xbepuE4MtsJXZHAr/wk41jtn9ymNGIG2+KAJ+JMHLSP2kht2vDqPbATyQ4am1Duv3mMeu4Sm4kLjCJIJhAYt5wquSornOmsvN0oT6700lJ4sLXkZUr9SOrZeHy2A+3ByKKNqjkmr4+9QdW+lO7t3w33PEgL/x3lCZswkAkxn+VGpLUfZ8vitmZsh/pbqGkaiLk2yn0Ow==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Paul Durrant" <paul.durrant@xxxxxxxxxx>
  • Delivery-date: Wed, 31 Mar 2021 14:00:27 +0000
  • Ironport-hdrordr: A9a23:wWqKl6F2lX6tqU8WpLqFk5XXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJVJxgd/mpCyxFNg9yNeKmZrY+Nv25V0Fd3AOV4hL6QBlBgGHVm1aLTM2S6YRPp ya+8ZBun6EcXMYcsy0ChA+LpT+jvfMk4/rZgNDOgUu7xOAgSjtxLnxFRWZ2Rl2aUIP/Z4J92 /Znwvlopiyqv3T8G6S60b/zbRz3OHgxNxKGdCWhqEuRAnEpw60aO1aKsS/lR8vpuXH0idIrP DtpFMaM913+zfteAiO0GHQ8i3B9Bpr1HP401+fhhLY0IzEbRY3EdBIi44cUjax0TtZgPhG3K hG332UuvNsZHuq9kWc2/HyWx5njUayq3Y5+NRj9EB3aocCdKRX6bUW4UI9KuZbIAvB9IslHO NyZfusgMp+TFKAY3jV+klpzdC8N05DeCuuf0kYtsSZlwVRhXBypnFoo/A3o3FozuNed7B0o8 D/doh4nrBHScEbKYhnAv0afMexAmvRBTrRLWO7Oz3cZeI6EkOIj6SyzKQ+5emsdpBN5oA1go 79XFRRsnN3U17yCPeJwIZA/nn2MSeAdAWo7vsby4lyu7X6SrauGzaEUkoSn8yppOhaJcHHRf CpOtZzD+X4JWXjXaZFtjeOHqV6GD07aok4q9w7U1WBrobgMYvxrNHWd/7VOf7jCjAhVmTjAm YSXTT6Kclah3rbHUPQsVz0YTfAa0b/9ZV/HOzx5O4I0rUAMYVKr0wUhD2Cl4e2AAwHlpZzUF p1IbvhnK/+j3Kx53z042JgPQcYCk5U5b7nQm5bvANiCTKsTZ8z//GkPUxC1nqOIRFyC+nMFh REmlhx8aWra5qKxS4jDNqjOnmAj2QaoW+LS5t0oNzG2e7VPrcDSro2Uq14EgvGUzZvnxxxlW tFYAgYAlPEGij2kqWjhpwMDOTZf91x6T3befJ8mDb6jwGxtMsvTnwUU3qSSsaRmx8pXCcRrE Z26bUjjL2JniuPJWMzjP8jCkBFbH2aDdt9fV+4TbQRvoquWQlrCU+WmDSRingICxXX3nRXol akEAq5VrXgBEFHtnVRz6DwmWkECFm1TgZXcXB1sYp0CGLcnG18uNX7O5ab23eNa1cE3+EWOC zEZzxXOQ9129Wrzneu6Ua/PGRjyZM0MuPHCrM/N7nVx3O2MYWN0boLBvlO4f9eRZ3Tm/5OVe qefgOPRQmIet8BykiQpnw/PjNzp2RhmfT02Af95GzQ5g91PdPCZFBnTaocOdeS8iztQOuJyo xwiZYwsfGrOmv8Lt6Axqe/VU8IFjrD5Wq3Rfovs5ZaoOY7s6ZyBYDSVX/Qz25ctS9OWvvchQ cbWuB28brBMohgc4gbfD9Y5EMgkJCKIFEwugL7D+cidTgW/jPmFsLM56CNpaskA0WHqge1I1 WZ/iFH9/rOXieI19cheuoNCHUTbFJ55GVp/euEeYGVFR6jcPtb+kGmdnC6a71QRcG+aMIthw c/58vNmeCZdyD1gl+N+TR6J79D6GahT4e5BhmWFetB7ty9PhCNj8KRkbuOpSayTSH+bUISwZ BBfwgXaM9IjzE5lo050iSoUMXM0wsYukob5Ssij0Ln34it/XzSEk5HOxDIm5k+Z0ggDlGYyc DetfWC3Hvz4DJZyYDOGUdZcNZJAcURROHMXlNTANlVuqWp8aopijlCZxlrD3dUskGP499b
  • Ironport-sdr: RFUFnkbk78ExsT18S79ZdaepB3Y3LQ8oQFjtkHrSE/j632kVbxrm+LjQupVDLqclEnuwT5uOYs BD3SA4TUbbigz92A4x9NqF5F3Kn7ZSX9x5g9JdoyBhP16tTeYqsUvm+fql5CkMSjUcExL+fo2h Xy/gZgew9dVmUhPBtIsyNTB4voEpkDZ9hDyvS4wOsIUBdNxvJ27q+qQxpq4qCG2DMI5CadoFah WXaaaHHNGaPNCRy/Gv6/TvPskE3aSjfP2ziSNE6ajGzaXS4ZiYAo6gndhFhxBxE4SkTEg8+qlX JP4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXINLTS489UfL61EKD4pjlwXnfbqqUSZCAgAbMCwCAABhsgIAAEbyAgAEUfwCAAdQ2AIAAAIoAgAABtoA=
  • Thread-topic: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code


> On Mar 31, 2021, at 2:54 PM, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 31.03.2021 15:52, Ian Jackson wrote:
>> George Dunlap writes ("Re: [PATCH] CHANGELOG.md: Make PV shim smaller by 
>> factoring out HVM-specific shadow code"):
>>> I don’t understand why the two of you are downplaying your work so much. 
>>> Yes, these are all only incremental improvements; but they are 
>>> improvements; and the cumulative effect of loads of incremental 
>>> improvements can be significant.  Communicating to people just what the 
>>> nature of all these incremental improvements are is important.
>> 
>> I agree with George here.
>> 
>> There ae a number of reasons why behind-the-scenes work with little
>> (intentional) user-visible impact are useful to note in the
>> CHANGELOG.md.  With my Release Manager hat on I would like to see, for
>> example,
>> 
>>>> + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer
>> 
>> something about htis work in the CHANGELOG.md.
>> 
>> IDK precisely, and I don't think George does either, what a good and
>> accurate statement is.  But I guess we will go with the text above if
>> we don't get something better.
> 
> At the very least the part after the comma ought to be deleted. As
> said in an earlier reply, at least the shim default config disables
> shadow code anyway, so the factoring out has no effect there.

Thanks.  So when you wrote the series, what was your motivation?  Did you have 
a particular technical outcome in mind?  Or did it just bother you that there 
was HVM-only code in a PV-only build? :-)

 -George

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.