Re: [PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 29/03/2021 17:23, Jan Beulich wrote:
> On 29.03.2021 18:12, George Dunlap wrote:
>>> On Mar 25, 2021, at 7:08 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>> On 24.03.2021 18:26, George Dunlap wrote:
>>>> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
>>>> ---
>>>> Missed one from my list when creating the other series
>>>>
>>>> CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
>>>> CC: Jan Beulich <jbeulich@xxxxxxxx>
>>>> CC: Roger Pau Monne <roger.pau@xxxxxxxxxx>
>>>> ---
>>>> CHANGELOG.md | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/CHANGELOG.md b/CHANGELOG.md
>>>> index 15a22d6bde..49832ae017 100644
>>>> --- a/CHANGELOG.md
>>>> +++ b/CHANGELOG.md
>>>> @@ -18,6 +18,7 @@ The format is based on [Keep a 
>>>> Changelog](https://keepachangelog.com/en/1.0.0/)
>>>>  - x86_emulate: Expanded testing for several instruction classes
>>>>  - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6
>>>>  - CI loop: Add dom0less aarch64 smoke test
>>>> + - Factored out HVM-specific shadow code, allowing PV shim to be slimmer
>>> But shadow code doesn't get included by default in shim-exclusive
>>> builds (and others are unlikely to disable HVM).
>> Can you propose some better text please?
> Does this need mentioning here in the first place?

I would recommend not.

We've been doing incremental improvements for the shim for several
releases now, and in this case, we're literally talking a few kb of
code.  As we already align to 2M boundaries for superpage reasons, there
almost certainly isn't actually a reduction in runtime size.

~Andrew