[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Date: Thu, 25 Mar 2021 09:04:37 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BxILtFVAFYqFLUO+ZUtbAacCYZULn4s7jJwSLI0/ogE=; b=BTZNBQefvXOZqzYIBXE2kOxEWczoK5bND1lRrHjUfxlcAOgNETFfO4UGNgT/KzEoKBR1i1+T1agin8CiYm6SrjnzyAzQnG5ZxLbpvRUrJ4kZxjwXjV2BQCe4nEZ9iE2UuGGyYrHsCtOaYCi32ztxj6UiF2tP3gS63f79uzq4zUPudwIR1Oeq0McGpUlFp5kjS0l9etmlAzFI+9g8OIzhu7gxGi2nwTQKksVK3p8jPEGmgYLUmjncynHOnCUUeaO5mqYeXtc5jlenxvh7t6SpBdvqBt+Ux93FCTrjLcYlNOLOV2hpFPXLSdpz+Uc9G3OggnqnJAlDn+GzrfbAL9kRWg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0TdoZaFhwf3qAVBSch5O/1IacmNFUqcwKU4t6FMYNXlWmtOiuK6ICqsT+7iTH5ZhNy9lJm9OKCskCfH8GcMSoEw682c1wFDZV9pglpWiS8As8ftYZurvlVYJv99FCGRwcUDlHY0dNWhSrLK4ECS2VMiemEUuTPdhM7xU8gtM1RwLWVWWjS0J2sINOltrjlEioRSZY8QE+SDA1SvXtf6K+wMzyb9GwHWadl6AXKE24WMRpKP2Fj2G0JNiUrTpPSDkp5uOLlOOJB/NB9elS6U7p8T35Civ5KRi9Izgc4vG7VM+JkmFGJ92YhhPmzrOchdh7NBsBRo7cc0ncGXEfKA4Q==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 25 Mar 2021 09:05:24 +0000
  • Ironport-hdrordr: A9a23:Eb0XH6B5oFN3IQ7lHejRtceALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPvfVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VLdMgXE3Kpm2a 9kGpITNPTZB1J3lNu/xQG+HcopztXvytHVuc715R5WPGVXQotn6Bp0DRveMmAefngGObMSEp 2A6s1b4x+pfnoKZsq2b0N1INTrjdvNiZ7gfFo6HBYh8gaDlneF77T9Hhie0H4lInNy6J0l9n XIlBG827W7v5iAu1Hh/kLwz7ATotvuzdNfGNeB4/J1FhzAghulDb4RI4GqkysypIiUmTQXuf nK5ywtJsFir07WF1vF3CfF/ynF/HIQ52T5yVme6EGT4vDRYD4hEcJOicZ4X3LimjEdlepx2q 5KwG6V3qA/ZXir8USNhOTgbB1kmlG5pnAvi4co/gZieLATdaNLqsgn9F5Vea1wQR7S0pwtE+ VlEajnlZFrWG6adHzQsy1Ox9GhTx0Ib267a3UCocCc3nxqmml4xSIjtaoit0oHnahNLqVs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SCU6PLtBEB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMy12oFR+BylehT5YR3djuVlo7RpsLz1Q7TmdQeZTko1rsemq/IDRurWRu i0I5ATJ/P4N2PhFcJo0mTFKt1vAEhbdPdQlscwWlqIrM6OAJbtrPbnfPHaI6eoHi0jXm/5H3 sfTDn+LMhN9SmQKznFqSmUf0moVl30/Jp2HqSf1fMU0pIxOopFtRVQiVnR3LDTFRRy9ogNOG duKrLula224UOs+3zT0mlvMh1BSkJc4LDqVWJWtRYHWnmEKYoripG6QyR/zXGHLhhwQ4f9Cw hEvWl6/qqxMtiX3iAtC9WuN2qAlHsNrHeWT5MR85fzovvNS9cdNNILSaZxHQLEG1heggBxsl pObwcCWwvCDD/0kL6ki5YVHenbcNF5jG6QUJVpgEOakX/ZidAkR3MdUTLrbNWehhw2QSFIwn dr9bUEvbaGkTGzCGc2jegiKmdQYGCPDL8uNnXeWKxk3pTQPCB5VyOjmCGTgRBbQBuVy2wiwk jaaRCyVd6OKFxHoXxc2rvt6zpPBxSgVnM1TGt7v417HXnBoVBp34awF/aO+mOMd1oPxfwcOj nZYT0UZhhj3cyzyQT9okfwKVw2gpopJeDTF7IlbvXa3W6sMpSBkeUcE+ZT54sNDqGjjsYbFe aWewqYN1rDepMU8h3QonYuIy9vrnY41fvuxR3+9WC9tURPS8b6MRBjR7sBJcub4HWhT/GU0I 9hhdZwueerKG3+ZpqHzq7QBgQzZy/7sCqzT+syr4pTsr93vLxvH4PDWT+NzWpZxnwFXY7JvV JbRL4+7KHKO4dpccBXcyVF/kAxnNDKKEcwqAT5DuI3YFlFtQ6VA/qZp77T7bY/CEyIowX9fU OS9CBQ5P/JVSqO37xyMdN6HU1GLEwnrHhy9uKLcIPdTBiwf+ZY5VygLzuzdqReRKXtI8Rnkj 9qp9WT2+mZeCrz1FqO4X91IqdS/32mRs33CgSWAuJM+8G7P1PJgqbC2r/GsB7nDT+gL0Ifjs lZcEZVaMJJgDwrlpc23Si/UbafmDNsr3JOpTV80kfw0Y2n6nrBFU5IMQfFkoxbNAMjR0SgnI DA66yEz3zz7zhOxInbGEpRdt9IHcIMToKfFVYYFeEA+Liy/6QuhSxfYBAhS24k4QqNrd9b4Q ==
  • Ironport-sdr: o1KAk7uCs/AqqLdqZNUONwRp8MYvm7L09n/fY87w5TZ7q2X6bIJvGs5OUudU5zfRjVEMWncu7f y9piKaQK3F9dIIZtFD2Hq9dn7WVf4pRynUdMfFTEMoHtdycI23rAHkGyyLswPcekBRTW42sEW7 NHblFRRUTTZNVkTa1dDgoN5Wnq2fxcmuyqevRHuXw2eV6sEXbk47fSqx/wfvKAa1L5o3AqOepI C3uDyee8+WLj7YrnDP1nzI99HQrw14OZ7TH3YVMmkc4u+Oo78xjBDb8C2lP7+JSc27Avx6zw/a Zjo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXIMzvj/osZBndl0iN655u2tDs9qqUV1aAgAAS04A=
  • Thread-topic: [PATCH 5/6] CHANGELOG.md: Add entries for emulation


> On Mar 25, 2021, at 7:57 AM, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 24.03.2021 17:44, George Dunlap wrote:
>> --- a/CHANGELOG.md
>> +++ b/CHANGELOG.md
>> @@ -14,6 +14,8 @@ The format is based on [Keep a 
>> Changelog](https://keepachangelog.com/en/1.0.0/)
>>  - Named PCI devices for xl/libxl
>>  - Support for zstd-compressed dom0 kernels
>>  - Library improvements from NetBSD ports upstreamed
>> + - x86_emulate: Support AVX-VNNI instructions
>> + - x86_emulate: Expanded testing for several instruction classes
> 
> TBH both seem too minor to me to be mentioned here. If I was to pick
> just one, I'd keep the former and drop the latter.

It’s always quite difficult in these releases to help express to people exactly 
what’s happened.  We’ve got over 1000 changesets — what have we been doing?  If 
my star chart is correct, the latter represents nearly 1700 extra lines of 
codes in tools/tests/x86_emulator/predicates.c.  It’s actually a reasonable 
chunk of code churn, which I think is worth highlighting.

Re the former, I think letting someone know that a new instruction is emulated 
is worthwhile.

Ian is the maintainer, so ultimately I think it’s his call?

 -George

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.