[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH for-4.15] x86/dmop: Properly fail for PV guests

  • To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 25 Feb 2021 17:09:36 +0000
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Thu, 25 Feb 2021 17:10:33 +0000
  • Ironport-sdr: COegb4ZToJqx916T8zRxHV6xoRQ9dWyjVxY4ybCI4Wamia0/emKp4ch94xhJY8KnYWQq8fJeaQ 8N+hjidaM9JqLF9WwQkJ3k5/WiTuZTVSgQSNGDC2q8a3CPGWqr6ac05unLW4ytuG/KhoTKP18h QXkwoxaxeENybYC1GjPqj0LCIFixkzmjnUM1vG8eR0WySu/8LLSHY930kigrmzz3X4wBcGK0pV kM0E5g5N+9S1VTm4xnoN6mvAjFHQ+prBPhCHfPLa88MXJ5mU+v/hcsUrX65uSW0m71yGEsKodF Dsk=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The current code has an early exit for PV guests, but it returns 0 having done

Fixes: 524a98c2ac5 ("public / x86: introduce __HYPERCALL_dm_op...")
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Wei Liu <wl@xxxxxxx>
CC: Ian Jackson <iwj@xxxxxxxxxxxxxx>
CC: Paul Durrant <paul@xxxxxxx>

For 4.15.  Found while testing XEN_DMOP_nr_vcpus.  Needs backporting to all
stable releases.
 xen/arch/x86/hvm/dm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
index 5bc172a5d4..612749442e 100644
--- a/xen/arch/x86/hvm/dm.c
+++ b/xen/arch/x86/hvm/dm.c
@@ -365,6 +365,7 @@ int dm_op(const struct dmop_args *op_args)
     if ( rc )
         return rc;
+    rc = -EINVAL;
     if ( !is_hvm_domain(d) )
         goto out;



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.